Date: Mon, 9 Apr 2018 10:18:35 -0500 From: Kyle Evans <kevans@freebsd.org> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Kyle Evans <kevans@freebsd.org>, Niclas Zeising <zeising+freebsd@daemonic.se>, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r331880 - stable/11/etc Message-ID: <CACNAnaHqiXfOziCxr4PeM-YZV24XCX2D9DiGW%2BvNg07Jj_Xk1Q@mail.gmail.com> In-Reply-To: <201804091514.w39FEPRv019139@pdx.rh.CN85.dnsmgr.net> References: <CACNAnaHpOTZMWRFjmbv5J8xu3tA2tLvOwZpT6_vyjhu6442TVQ@mail.gmail.com> <201804091514.w39FEPRv019139@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 9, 2018 at 10:14 AM, Rodney W. Grimes <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] >> On Mon, Apr 9, 2018 at 9:46 AM, Rodney W. Grimes >> <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: >> >> On 04/02/18 17:39, Rodney W. Grimes wrote: >> >> >> Author: kevans >> >> >> Date: Mon Apr 2 15:28:48 2018 >> >> >> New Revision: 331880 >> >> >> URL: https://svnweb.freebsd.org/changeset/base/331880 >> >> >> >> >> >> Log: >> >> >> MFC r328331: Support configuring arbitrary limits(1) for any rc.conf daemon >> >> >> >> >> >> Usage is ${name}_limits, and the argument is any flags accepted by >> >> >> limits(1), such as `-n 100' (e.g. only allow 100 open files). >> >> >> >> >> >> Modified: >> >> >> stable/11/etc/rc.subr >> >> >> Directory Properties: >> >> >> stable/11/ (props changed) >> >> >> >> >> >> Modified: stable/11/etc/rc.subr >> >> >> ============================================================================== >> >> >> --- stable/11/etc/rc.subr Mon Apr 2 15:07:41 2018 (r331879) >> >> >> +++ stable/11/etc/rc.subr Mon Apr 2 15:28:48 2018 (r331880) >> >> >> @@ -773,6 +773,8 @@ check_startmsgs() >> >> >> # >> >> >> # ${name}_login_class n Login class to use, else "daemon". >> >> >> # >> >> >> +# ${name}_limits n limits(1) to apply to ${command}. >> >> >> +# >> >> > >> >> > Caution, limits(1) is in /usr/bin, this code can fail if used before >> >> > /usr is mounted. (Ie, our rc.initdiskless) is probably broken by >> >> > this change if a call is made to limits. >> >> > >> >> > >> >> >> >> Sorry for jumping on this so late. This is also an issue in CURRENT, >> >> and has been since at least 2016. >> > >> > I was aware that it was an issue and why I made a comment about it >> > being MFC'ed. Though I had forgot a bug report existed. >> >> I'm kind of surprised we haven't had more complaints about this- the >> original commit for this stuff landed before stable/11 was even >> branched, so it's been broken for all of 11.x's lifetime. > > History has taught me it takes a long time for this type of > breakage to usually surface in a noticable way. Also I think > until you merged this last ${name}_limits thing it actually > didn't cause an issue, except for the few like me running > diskless systems and or seperate /usr. I don't see how this merge could possibly have been the cause of any claimed issues- like I said before, it didn't add any limits invocations, it added an arg to the limits invocation that already existed. You can see this pretty clearly from the diff, we didn't even change any conditions for limits to be invoked. > > This latest issue is a name space collision between base and ports. > > People who see limits issues due to missing /usr files usually > know how to work around it, and they do, they just cp /usr/bin/limits > to /bin, and do not submit a bug report or send an email. > That saddens me. =/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHqiXfOziCxr4PeM-YZV24XCX2D9DiGW%2BvNg07Jj_Xk1Q>