From owner-freebsd-hackers@FreeBSD.ORG Fri Feb 5 14:00:47 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AA7951065670 for ; Fri, 5 Feb 2010 14:00:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 218BF8FC23 for ; Fri, 5 Feb 2010 14:00:46 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o15E0dqm023260 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 5 Feb 2010 16:00:39 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id o15E0d3h070024; Fri, 5 Feb 2010 16:00:39 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id o15E0di6070023; Fri, 5 Feb 2010 16:00:39 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 5 Feb 2010 16:00:38 +0200 From: Kostik Belousov To: Andrew Gallatin Message-ID: <20100205140038.GR15587@deviant.kiev.zoral.com.ua> References: <4B6B30BC.7030107@cs.duke.edu> <20100205100643.GQ15587@deviant.kiev.zoral.com.ua> <4B6C225D.3020306@cs.duke.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vIXBmblrD40XNCy4" Content-Disposition: inline In-Reply-To: <4B6C225D.3020306@cs.duke.edu> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-hackers@freebsd.org Subject: Re: devfs panic w/INVARIANTS X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2010 14:00:47 -0000 --vIXBmblrD40XNCy4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 05, 2010 at 08:51:25AM -0500, Andrew Gallatin wrote: > Kostik Belousov wrote: > >On Thu, Feb 04, 2010 at 03:40:28PM -0500, Andrew Gallatin wrote: > >>I've got a commercial driver that uses device cloning. > >>At unload time, the driver calls clone_cleanup(). When I unload > >>the driver when the kernel is built with INVARIANTS, I'll see a > >>panic in devfs_populate_loop(). This happens in 6-stable, > >>as well as 8-stable. > >> > >>From what I can see the clone has been freed, but it > >>remains on the devfs cdevp_list. Then the next time > >>devfs_populate_loop() is called, it trips over the bad > >>entry (cdp->cdp_dirents points to 0xdeadc0dedeadc0de) > >>See appended kgdb session. > >> > >>If I trace the code path, it looks like clone_cleanup() > >>calls destroy_devl(). And destroy_devl() will eventually > >>call devfs_free() if the si_refcnt is zero. But I don't > >>see anything which will get the cdev removed from > >>the cdevp_list prior to it being freed. > >> > >>The only code I see which will get the cdev removed from > >>the cdevp_list() seems to be the "GC any lingering devices" > >>block in devfs_populate_loop > >> > >>What am I missing? > > > >You did not mentioned it, but my guess is that you create clones from > >the dev_clone event handler. Please note that devfs_lookup() that fires >=20 > Yes, I do. >=20 > >dev_clone event, consumes a device reference. Thus clone handlers shall > >do dev_ref(). > > > >Due to races with cleanup, you should use MAKEDEV_REF flag for > >make_dev_credv(9) KPI instead of doing make_dev()/dev_ref() pair. >=20 > I need to support FreeBSD going all the way back to 6, so that's not an > option in some versions. >=20 > But, I'm talking about device removal time. If I call clone_cleanup() > where the clones have dev->si_refcount=3D=3D1, then I get the use-after-f= ree > panic. If I hack things to elevate the reference count (such that > dev->si_refcount=3D=3D2 when clone_cleanup() is called), then I don't > get the panic. >=20 > Are you saying I should have been taking the extra reference > via my dev_clone eventhandler? Won't having the extra reference > lead to a memory leak? Or am I just mis-reading the code, and > this will lead to things being freed normally? Yes, clone handler shall do dev_ref(). Either by doing race-free make_dev_credf(MAKEDEV_REF) call, or by using dev_ref() after make_dev(). >=20 > >That said, do you really need clones at all ? >=20 > I need to support FreeBSD back to 6.x, and I need to support the > linux-like model of opening the "same" /dev/node multiple times > and getting unique handles. So I think I need clones. Wouldn't it be cleaner to use cdevpriv for the 7/8/HEAD where it is present ? And have special #ifdef-ed code for 6, that could be eventually dropped. --vIXBmblrD40XNCy4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAktsJIYACgkQC3+MBN1Mb4gZxwCfUVGiWLuSHITnOqzaTVAKE8K3 oBgAn1PJj+NO92S5+md5KAVxQ8Pn1DPH =R2Ko -----END PGP SIGNATURE----- --vIXBmblrD40XNCy4--