From owner-cvs-all Tue Jun 22 1:14:50 1999 Delivered-To: cvs-all@freebsd.org Received: from herring.nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (Postfix) with ESMTP id 6E4B314D4F; Tue, 22 Jun 1999 01:14:40 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from localhost (dfr@localhost) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id JAA20160; Tue, 22 Jun 1999 09:15:57 +0100 (BST) (envelope-from dfr@nlsystems.com) Date: Tue, 22 Jun 1999 09:15:57 +0100 (BST) From: Doug Rabson To: Guido van Rooij Cc: Peter Wemm , cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/isa sio.c In-Reply-To: <19990621221816.A28898@gvr.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Mon, 21 Jun 1999, Guido van Rooij wrote: > On Mon, Jun 21, 1999 at 10:37:27AM +0100, Doug Rabson wrote: > > > > I would rather that people tackle these weaknesses by asking me how to > > solve their problem or by suggesting new functionality for the 'approved' > > api. I really think its a bad idea for drivers to use bus_private.h at > > all. > > You could actually even enforce this with some #define/#ifdef combination. > (#define MAY_USE_INCLUDE_FILE in file.c > #ifndef MAY_USE_INCLUDE_FILE > #error Do not use this include file > #endif > > At least occasional errors like the one in sio.c can be prevented. Bruce had the same idea. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message