From owner-svn-src-all@freebsd.org Mon Oct 29 20:27:10 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46EF610E9241; Mon, 29 Oct 2018 20:27:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F2487810CD; Mon, 29 Oct 2018 20:27:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 5BE3110AFD2; Mon, 29 Oct 2018 16:27:08 -0400 (EDT) Subject: Re: svn commit: r339826 - in head: sys/amd64/vmm/intel usr.sbin/bhyve To: Yuri Pankov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201810272124.w9RLOTpU054208@repo.freebsd.org> From: John Baldwin Message-ID: Date: Mon, 29 Oct 2018 10:24:37 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201810272124.w9RLOTpU054208@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 29 Oct 2018 16:27:08 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 20:27:10 -0000 On 10/27/18 2:24 PM, Yuri Pankov wrote: > Author: yuripv > Date: Sat Oct 27 21:24:28 2018 > New Revision: 339826 > URL: https://svnweb.freebsd.org/changeset/base/339826 > > Log: > Provide basic descriptions for VMX exit reason (from "Intel 64 and IA-32 > Architectures Software Developer’s Manual Volume 3"). Add the document > to SEE ALSO in bhyve.8 (and pet manlint here a bit). > > Reviewed by: jhb, rgrimes, 0mp > Approved by: kib (mentor) > Differential Revision: https://reviews.freebsd.org/D17531 I did ask you to commit the bhyve.8 style fixes separately from the content changes in the review. While it is true we don't currently have active translations of manpages, it is still a good practice to follow to not mix style changes with content changes even in code commits as it obfuscates the content changes. -- John Baldwin