Date: Mon, 29 Oct 2018 10:24:37 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Yuri Pankov <yuripv@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339826 - in head: sys/amd64/vmm/intel usr.sbin/bhyve Message-ID: <e877de10-6522-5e97-2cff-cb820d14772f@FreeBSD.org> In-Reply-To: <201810272124.w9RLOTpU054208@repo.freebsd.org> References: <201810272124.w9RLOTpU054208@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/27/18 2:24 PM, Yuri Pankov wrote: > Author: yuripv > Date: Sat Oct 27 21:24:28 2018 > New Revision: 339826 > URL: https://svnweb.freebsd.org/changeset/base/339826 > > Log: > Provide basic descriptions for VMX exit reason (from "Intel 64 and IA-32 > Architectures Software Developer’s Manual Volume 3"). Add the document > to SEE ALSO in bhyve.8 (and pet manlint here a bit). > > Reviewed by: jhb, rgrimes, 0mp > Approved by: kib (mentor) > Differential Revision: https://reviews.freebsd.org/D17531 I did ask you to commit the bhyve.8 style fixes separately from the content changes in the review. While it is true we don't currently have active translations of manpages, it is still a good practice to follow to not mix style changes with content changes even in code commits as it obfuscates the content changes. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e877de10-6522-5e97-2cff-cb820d14772f>