From owner-freebsd-current@FreeBSD.ORG Mon Oct 13 09:47:45 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E748616A4B3 for ; Mon, 13 Oct 2003 09:47:45 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id E8B3543FB1 for ; Mon, 13 Oct 2003 09:47:44 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 28195 invoked by uid 1000); 13 Oct 2003 16:47:45 -0000 Date: Mon, 13 Oct 2003 09:47:45 -0700 (PDT) From: Nate Lawson To: Mark Santcroos In-Reply-To: <20031013124917.GA889@laptop.6bone.nl> Message-ID: <20031013094449.W28158@root.org> References: <200309152116.h8FLGld2085395@repoman.freebsd.org> <20031013124917.GA889@laptop.6bone.nl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: current@freebsd.org Subject: Re: cvs commit: src/sys/dev/sound/pci ich.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Oct 2003 16:47:46 -0000 On Mon, 13 Oct 2003, Mark Santcroos wrote: > On Mon, Sep 15, 2003 at 02:16:47PM -0700, Nate Lawson wrote: > > njl 2003/09/15 14:16:47 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/sound/pci ich.c > > Log: > > Correctly reset ich[3-5] sound cards on resume. This fixes audio playback > > after suspend/resume for me. > > > > Submitted by: iwasaki > > Reviewed by: orion > > Approved by: cg > > Hi Nate, > > Sorry for the late reply, this breaks resuming from S4BIOS on my Latitude > C640. > > In message <20030609035127.GA36909@laptop.6bone.nl> to current@ in June I > posted my fix. I just tried to find your message through the web search interface. No such luck. (Speaking of which, the mailing list search interface is HORRIBLE. It only seems to check the first word entered.) > While it was not very clean, it worked: > > # set nambar > pciconf -w -b pci0:31:5 0x11 0xd8 > # set nabmbar: > pciconf -w -b pci0:31:5 0x14 0x81 > pciconf -w -b pci0:31:5 0x15 0xdc > # set pcicmd: > pciconf -w -b pci0:31:5 0x4 0x5 > > I also did the same thing at resume in ich.c, don't have the patch at hand > right now, but you get the idea. > > It would be nice if we could get your changes also to work on my system. It looks like you are resetting the BARs on resume. If that's all that's needed, I believe Warner was working on code to do this in the general case. -Nate