From owner-freebsd-ia64  Fri Jan  3 22:45:47 2003
Delivered-To: freebsd-ia64@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6496B37B401; Fri,  3 Jan 2003 22:45:46 -0800 (PST)
Received: from cleitus.hosting.swbell.net (cleitus.hosting.swbell.net [216.100.99.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7C04743ED8; Fri,  3 Jan 2003 22:45:45 -0800 (PST)
	(envelope-from alc@imimic.com)
Received: from imimic.com (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18])
	by cleitus.hosting.swbell.net
	id BAA16453; Sat, 4 Jan 2003 01:45:34 -0500 (EST)
	[ConcentricHost SMTP Relay 1.14]
Message-ID: <3E16830D.F7D8507D@imimic.com>
Date: Sat, 04 Jan 2003 00:45:33 -0600
From: "Alan L. Cox" <alc@imimic.com>
Organization: iMimic Networking, Inc.
X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Arun Sharma <adsharma@unix-os.sc.intel.com>
Cc: alc@freebsd.org, freebsd-ia64@freebsd.org
Subject: Re: Assertion failure in vm_page.c:289
References: <20030103180935.A3170@unix-os.sc.intel.com> <20030103183441.A3425@unix-os.sc.intel.com>
Content-Type: text/plain; charset=x-user-defined
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-ia64@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ia64.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ia64>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ia64>
X-Loop: FreeBSD.org

Arun Sharma wrote:
> 
> Looking at i386 code, this seems to be the missing lock.
> 

Yes, that looks plausible.  I'll commit the change shortly.

Thanks,
Alan

> 
> --- pmap.c-     Sat Jan  4 00:14:49 2003
> +++ pmap.c      Sat Jan  4 02:30:57 2003
> @@ -1694,7 +1694,9 @@
>          */
>         if (opa) {
>                 int error;
> +               vm_page_lock_queues();
>                 error = pmap_remove_pte(pmap, pte, va, 0, 0);
> +               vm_page_unlock_queues();
>                 if (error)
>                         panic("pmap_enter: pte vanished, va: 0x%lx", va);
>         }
> 
> On Fri, Jan 03, 2003 at 06:09:35PM -0800, Arun Sharma wrote:
> > Alan,
> >
> > It looks like you added this assertion on Dec 28th.
> >
> > void
> > vm_page_flag_clear(vm_page_t m, unsigned short bits)
> > {
> >
> >         mtx_assert(&vm_page_queue_mtx, MA_OWNED); <-----
> >         m->flags &= ~bits;
> > }
> >
> > and I'm seeing the assertion failure right at startup (after execing
> > /sbin/init) on a ia64 box. Is it possible that there was an accompanying
> > change that was made to i386, but not ia64 ?
> >
> >       -Arun

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ia64" in the body of the message