From owner-svn-ports-head@FreeBSD.ORG  Fri Apr 26 03:51:32 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id F1A87619; Fri, 26 Apr 2013 03:51:32 +0000 (UTC)
Date: Fri, 26 Apr 2013 03:51:32 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Alex Kozlov <ak@FreeBSD.org>
Subject: Re: svn commit: r316515 - head/graphics/gdk-pixbuf2
Message-ID: <20130426035132.GA77202@FreeBSD.org>
References: <201304251344.r3PDid1c079303@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201304251344.r3PDid1c079303@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Apr 2013 03:51:33 -0000

On Thu, Apr 25, 2013 at 01:44:39PM +0000, Alex Kozlov wrote:
> New Revision: 316515
> URL: http://svnweb.freebsd.org/changeset/ports/316515
> 
> <...>
>   - Remove NLS from options, it's handled globally

It looks like we do need a policy on this issue.  Recently it was discussed
(google for "Re: svn commit: r315222") again for example.

I personally think that all options should be listed in OPTIONS_DEFINE, even
the global ones.  The nice thing here that if some option(s) will migrate
their local<->global status, we would not have to change OPTIONS_DEFINE in
thousands places across the tree.  It would also mean no diversity; right
now some people list them, while some don't.

As for addressing the annoyance part of the question, it should be solved
with separate knob, settable in /etc/make.conf, that users can set to skip
the global options in dialog (or disable skipping if it's on by default).
OPTIONS_DEFINE should not be abused for this purpose.

./danfe