From owner-svn-src-all@freebsd.org Sat Apr 15 05:37:35 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A1B74D3E52C; Sat, 15 Apr 2017 05:37:35 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 706A81546; Sat, 15 Apr 2017 05:37:35 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pf0-x241.google.com with SMTP id a188so17527165pfa.2; Fri, 14 Apr 2017 22:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5JArcHcnxcEoIM1ckH5QmZ5xTkdEOXllHClfyOnP4PY=; b=nr9GQg0xLiYYjNCAzppJeKuw1/qwEzBjCVPF4f2QjzIkIW7Fvww90h5nnKo3e4BNmn eOxPU+uTnxQ6ySrb3Pcaw+ernQqIhjpTPyOLRm7ZW4HOJxIGDNDiueJOGguLGD+Luzp5 0yQe7XYTz1jMOKnu9ZDv5kzp4rR3uLHPpcATTBqdD9Wl6JnElghJCElsoU7i/5dN7sR+ yO8HdjpxfU97EHno+LKwTL5EcKZaoQr+rkBEriMqwQqNcYWuGYqGtwUIp6Ad9UUNwAUh 5CLTIxmAQYu4C2dLJkmJdG2hNr//INCZ+d2+EvlLQm/3LbT+NbwtaortJVQ2IQ9+EIyo MLaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=5JArcHcnxcEoIM1ckH5QmZ5xTkdEOXllHClfyOnP4PY=; b=ZPSTXbmnu2I1bNxjNfCzKk+K8zWIteTPlSJ867Peu2gW1YrAQ899bNV4QtNIKolro/ ARCC7gjiCHxaPeYbzDYd4ai/iqwG579Sjy5mOFh5YKS6OSMr8slPB18R5POv7D/PwbM0 5azd5thgueE5+aaraWhz/Z0qX0sZ8H/nsuVqXIP9VbXIL4kXLQGSh+hCgg0vGDlesntv H6GZQ4VZR0vW07N8K58fgHdcIoO4JF/M6kElJILTlgKgj0b7R4hzcTT1sb7UnjZgfNMY N9uCihxJREG/ofj5MCbv6adYArDD+6aVC3OIXBJk4ZDF4m6jph9RmQxQUD/wysmFTkn4 +YAA== X-Gm-Message-State: AN3rC/6vb0yErzWgcZvDt2QN2B2BlqEu0TqxjOEx4eVFkpcZW7oL0wpL vI5YXqv6ZKjIpgBIgYU= X-Received: by 10.84.241.3 with SMTP id a3mr526981pll.117.1492234654884; Fri, 14 Apr 2017 22:37:34 -0700 (PDT) Received: from raichu ([2604:4080:1102:0:ca60:ff:fe9d:3963]) by smtp.gmail.com with ESMTPSA id e13sm6087558pfb.30.2017.04.14.22.37.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Apr 2017 22:37:33 -0700 (PDT) Sender: Mark Johnston Date: Fri, 14 Apr 2017 22:37:29 -0700 From: Mark Johnston To: rgrimes@freebsd.org Cc: Alan Somers , Ngie Cooper , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r316938 - head/sbin/savecore Message-ID: <20170415053729.GA76139@raichu> References: <20170414202918.GD5039@wkstn-mjohnston.west.isilon.com> <201704150130.v3F1UHpR009181@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201704150130.v3F1UHpR009181@pdx.rh.CN85.dnsmgr.net> User-Agent: Mutt/1.8.0 (2017-02-23) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Apr 2017 05:37:35 -0000 On Fri, Apr 14, 2017 at 06:30:17PM -0700, Rodney W. Grimes wrote: > > The patch to add compression support is here and should largely still > > work: > > https://people.freebsd.org/~markj/patches/core-compression/20141110-kern_dump.diff > > > > I've been hesitant about pushing it forward: > > - The dump_write* APIs need some simplification after the addition of > > encrypted dump support and support for dumping to 4Kn drives. > > - I'm not sure how encryption should compose with compression. It seems > > intuitively obvious that we should compress before encrypting if the > > compression is to be of any use, but I don't know enough to know > > whether the compression might somehow compromise the effectiveness of > > the encryption. > > > > If anyone has some insight on the second of these two points, I'd > > appreciate hearing it. > > I have a large amount of reworking and modulization of the dump code > incuding intergration of your (markj) compressed dumps. Layer isnt > implemented but is in the plan. I should not of held off on the net > dump code as it got smashed by encrypted dumps, then again by > the libif'ing for all the Intel drives that had been netdump modified. > > Basically now starting over :-( Could you post your patches somewhere? I've been sitting on this (and the netdump patches, for which I have quite a few modifications) for far too long, and would like to finish them and get them in soon. I'll note that the netdump code posted a few years ago had some problems that are fixed in Isilon's version, which I'm working on rebasing on HEAD. In particular, I simplified the driver integration a bit, changed the code to avoid allocating mbufs from UMA after a panic, plumbed a configuration interface through dumpon, and fixed some problems with netdumpd. I'm working on integrating netdump with Isilon's internal infrastructure at the moment. The conversion of em and igb to iflib does complicate things a bit; I haven't yet looked at how hard it would be to support netdump in iflib'ed drivers. > Minidump is an lkm for me, and main dump is almost an lkm for me too. Does "lkm" mean "loadable kernel module"? If so, why?