From owner-cvs-all  Sun Jul  7 15:33:53 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5527037B416; Sun,  7 Jul 2002 15:33:43 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0FECD43E3B; Sun,  7 Jul 2002 15:33:42 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id IAA30040;
	Mon, 8 Jul 2002 08:33:19 +1000
Date: Mon, 8 Jul 2002 08:36:20 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Don Lewis <dl-freebsd@catspoiler.org>
Cc: brooks@one-eyed-alien.net, <iedowse@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sbin/dump tape.c traverse.c
In-Reply-To: <200207072143.g67Lh10M023883@gw.catspoiler.org>
Message-ID: <20020708082008.J13478-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sun, 7 Jul 2002, Don Lewis wrote:

> On  7 Jul, Brooks Davis wrote:
> > On Sun, Jul 07, 2002 at 05:30:21AM -0700, Ian Dowse wrote:
> >> iedowse     2002/07/07 05:30:21 PDT
> >>
> >>   Modified files:
> >>     sbin/dump            tape.c traverse.c
> >>   Log:
> >>   Fix some printf format errors.
> >
> > Do we really want to fix printf errors wwith %qd?  A cast to intmax_t
> > and %jd is at least C99 compliant where as %qd is a FreeBSDism.
>
> There were already a bunch of %qd formats in the code, so the patch I
> suggested changed a bunch of %d formats associated with int64_t values
> to match.  I certainly wouldn't object if someone wanted to convert all
> the %qd formats to %jd.

%qd is just a different printf format error.  E.g., on alphas, it happens
to work, but it doesn't compile cleanly (since %qd is equivalent to %lld
which is for printing long longs, but int64_t is plain long).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message