Date: Thu, 14 May 2015 11:20:11 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: "Philip M. Gollucci" <pgollucci@p6m7g8.com>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r386285 - head/security/keychain Message-ID: <5554CB3B.9070807@FreeBSD.org> In-Reply-To: <5554C918.8090305@FreeBSD.org> References: <201505140101.t4E11r9T031351@svn.freebsd.org> <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org> <CACM2dAaFL6F-=mbfODTRrR83L%2BGeLfxzcM16DoroP1shmP6NHQ@mail.gmail.com> <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> <5554C761.3060609@FreeBSD.org> <07ED759D-DFAC-44D0-A22B-1639EE3E0CB8@adamw.org> <5554C8A1.50200@FreeBSD.org> <317F946C-1F0E-4F8E-B121-6442CC82BCAA@adamw.org> <5554C918.8090305@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WQj3mJsJAsqfTPvf4jeCpvlD0eRKRfxvf Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 5/14/2015 11:11 AM, Bryan Drewery wrote: > On 5/14/2015 11:10 AM, Adam Weinberger wrote: >>> On 14 May, 2015, at 10:09, Bryan Drewery <bdrewery@FreeBSD.org> wrote= : >>> >>> On 5/14/2015 11:07 AM, Adam Weinberger wrote: >>>>> On 14 May, 2015, at 10:03, Bryan Drewery <bdrewery@FreeBSD.org> wro= te: >>>>> >>>>> On 5/14/2015 11:00 AM, Adam Weinberger wrote: >>>>>>> On 13 May, 2015, at 21:20, Philip M. Gollucci <pgollucci@p6m7g8.c= om> wrote: >>>>>>> >>>>>>> Then it needs an option not an if exists() >>>>>> >>>>>> Bryan, can you please consider reverting it, or giving me approval= to revert it? It may fix the case when the port is built in poudriere wi= thout sshd in base, but it is a regression for everybody else. >>>>>> >>>>>> # Adam >>>>>> >>>>>> >>>>> >>>>> No. The way RUN_DEPENDS is supposed to work is what I said in the >>>>> commit. These exists() checks are redundant and confuse the package= >>>>> dependencies. >>>>> >>>>> How are you building? It's possible the tool you are using is >>>>> incorrectly handling RUN_DEPENDS. >>>> >>>> Ah! I see. It's portmaster that's doing the misbehaving. The problem= is that openssh-portable still shows up in run-depends-list, and so port= master decides that it is going to install openssh-portable first. >>>> >>>> [root@apnoea /usr/ports/security/keychain] which ssh-agent >>>> /usr/bin/ssh-agent >>>> [root@apnoea /usr/ports/security/keychain] make run-depends-list >>>> /usr/ports/security/openssh-portable >>>> /usr/ports/shells/bash >>>> >>> >>> Ok. I'll look at portmaster and try to fix it now. We really need the= se >>> exists() to go away; it causes rebuilds on the package cluster for no= >>> reason. This specific case is not one, but we need them to generally = go >>> away. >> >> Sorry about the noise, Bryan. >> >=20 > It's not noise! There's 2 bugs here. Portmaster installs and Poudriere > builds. Both need to be fixed :) >=20 >=20 Portupgrade also incorrectly installs. --=20 Regards, Bryan Drewery --WQj3mJsJAsqfTPvf4jeCpvlD0eRKRfxvf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVVMs7AAoJEDXXcbtuRpfP8AMIAJaATTskWtffmz+9/fPpzagZ 0w1hAHf6zMYHTS51Ut8twLZcZQKGZ3sgufKJMZUTckwuEtWqXZs0wSjGCzAuvILv e8AnCSlyI6tXpms1XKnxSM8C7JkytbaDvHAU3UwXROBXOhJaVS5LJAhAqHwNAKZU hGmaaoy7U3A2FvNBJDt+dd6xHr9VyO89od00sEdTw3psXOE1UzEIwDV4nRLStOdO lCUtdbNAcw1WZmNgjdCKrq8ie4RG/z6E63gCIBHmkhIb6rPaxmhjMb/JlFQpgACR yKT+x8cXm0ajuruu4n1OHPfeTw9mQ983a/u88klTzDCStCzW1v3xvX0p4pkfyYA= =qtGB -----END PGP SIGNATURE----- --WQj3mJsJAsqfTPvf4jeCpvlD0eRKRfxvf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5554CB3B.9070807>