Date: Tue, 19 Apr 2022 12:57:33 +0000 From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 259607] prometheus_sysctl_exporter: Need better encoding support for sysctl OIDs Message-ID: <bug-259607-3630-vTUH7ES3L7@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-259607-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-259607-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D259607 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D8c47d8f53854825d8e8591ccd06e32b2c= 798f81c commit 8c47d8f53854825d8e8591ccd06e32b2c798f81c Author: Alan Somers <asomers@FreeBSD.org> AuthorDate: 2022-04-18 21:29:37 +0000 Commit: Alan Somers <asomers@FreeBSD.org> CommitDate: 2022-04-19 12:56:39 +0000 prometheus_sysctl_exporter: fix metric aliasing When exporting sysctls to Prometheus, the exporter replaces "." with "_". This caused several metrics to alias, confusing the Prometheus server. Fix it by: * Renaming the "tcp_log_bucket" UMA zone to "tcp_log_id_bucket". Also, rename "tcp_log_node" to "tcp_log_id_node" for consistency. * Not exporting sysctls with "(LEGACY)" in the description. That is used by ZFS sysctls that have been replaced by others, many of which alias to the same Prometheus metric name (like "vfs.zfs.arc_max" and "vfs.zfs.arc.max"). PR: 259607 Reported by: delphij MFC after: 2 weeks Sponsored by: Axcient Reviewed by: delphij,rew,thj Differential Revision: https://reviews.freebsd.org/D34952 sys/netinet/tcp_log_buf.c | 33 +++++++++++-------= ---- .../prometheus_sysctl_exporter.c | 11 ++++++-- 2 files changed, 26 insertions(+), 18 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-259607-3630-vTUH7ES3L7>