Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Nov 1995 20:06:28 -0800
From:      asami@cs.berkeley.edu (Satoshi Asami)
To:        bde@zeta.org.au
Cc:        mark@grondar.za, CVS-commiters@freefall.freebsd.org, cvs-ports@freefall.freebsd.org, markm@freefall.freebsd.org
Subject:   Re: URGENT: Re: cvs commit: ports/security/pidentd/patches patch-ae
Message-ID:  <199511220406.UAA01754@silvia.HIP.Berkeley.EDU>
In-Reply-To: <199511220225.NAA22683@godzilla.zeta.org.au> (message from Bruce Evans on Wed, 22 Nov 1995 13:25:30 %2B1100)

next in thread | previous in thread | raw e-mail | index | archive | help
Thanks for your reply, Bruce.  Much appreciated.

 * In 2.1, <sys/sysctl.h> included <sys/ucred.h>.  Including <sys/ucred.h>
 * doesn't work unless NGROUPS is already defined.  NGROUPS is a POSIX value
 * that is defined in (a file included by) <limits.h>.  It also happens to
 * be defined in (a file included by) <sys/param.h> and in <sys/syslimits.h>.
 * 
 * Mark apparently fixed a problem for 2.1 by removing <sys/sysctl.h>.  The
 * correct fix was probably to include <limits.h> or <sys/param.h> or to
 * complain until someone fixes <sys/ucred.h>.

Aahh.  I see that <sys/param.h> included after <sys/sysctl.h>, I
reversed the order and it works fine now.

 * KERN_FILE is defined in <sys/sysctl.h>.  <sys/sysctl.h> is not included by
 * any other header.

Oops, I'm sorry.  I forgot to update the ports directory in my machine
before my previous post.  It works fine in -current.  Mark's patch was
to add an include of <sys/sysctl.h>.

I changed the order of includes and it now works fine on both -current 
and -stable.  Thanks for your help.

Satoshi



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199511220406.UAA01754>