From nobody Fri Oct 10 21:05:13 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cjzlt1HGPz6ByyX; Fri, 10 Oct 2025 21:05:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cjzls6NLZz3DCm; Fri, 10 Oct 2025 21:05:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760130313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OYkhNpejrBeVG/J9vq+42fDXkOmmHp4VM0288VLeKrg=; b=BYerdRInkP84pO5MnEsSgGr/mkT9ZqrBQ8+bIhP0/WG3JcE83wGFn10hvidSlUhaWv16jo q9//8j5HozILUildIacm1g32I/VG7YXjzyD3EF8+0eO60zE+/RCmc1Wtdr5TtI0zC9ib7Y RQ4CoWkd8OXhd+uCEo/qPMBT6j1eBMIq2gdpdCU6bbbNVeX6I+NOXVn5pM7856zJuY43Pa +dOlTjsHmaKpiz9zL7qH9UgfG8jl2Kfq5sC+zyyON7mgtl37lMQUcEn93xpD7S9kC6oMsz b/NgdaDZkGNe8Fqk86ZoNjNFE2gIaWZ2ynGrd0WKmVKI2Ty/JM6vaQoH34RdKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760130313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OYkhNpejrBeVG/J9vq+42fDXkOmmHp4VM0288VLeKrg=; b=RDFx7bMha2eSeniRKVkA6rfnxh9G5xaBsG2Ebi93hXhMAvUby3PusuDU3cAut0JPQGbvU0 BS2jJQGyS5KrugH9jAVOuva6BAq8Fm7+xyuUbJOKOqkhFRhwRRCk97q3eHfg4DxySA6Htm r2PSeQpjPvMWaTZnu6KLC8QEO2hD6iaNghWSTx3mWg65/9JiqOYdlre+wbTO1+IAbmxTn5 qBP/XTXfB9HHLkiUTCSwePlO3Cz1WrTdgCBYg+8JY5PveiwojFuJJWjgvYVd7x78O3jhlE a5Q5/QBxMBHLSNDdwsogo2MnKakgIW18rG+HuMVvquu5erj5XC+2Xuf6ksWILw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760130313; a=rsa-sha256; cv=none; b=BRbintMIE3ygkauXyLr16KKb15/Cac811PQS1aNOjMRaU82fakzlKpiJuMW2NmMEOUW5zK 8/pFMWogaLCgNjdJnshAdxEXIE5SDmgCVw4wZENYJuX76GJigeiUbUVtb0y/Xme27dNnw4 f/xOoOdCPUl1gPUD0/WUC7+cH09LMB1AvcM+0QmXXiNXjmgUQg4TrMqB1IYnnYNa6m3ij4 AOh28Xgbgvvnr7fx1QBdxiTaV7l+mF2f6eN6BQZ4r/Fn79+S9tQUkcsnhdN2ZGUIvKn25h 5mgemXoidx5+UgNdSufvLuyVe8K0W1i5lvUDJV5Q8FL7/2l1Zypv+cZYidDRDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cjzls5zgZz1Jb3; Fri, 10 Oct 2025 21:05:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59AL5DqM043529; Fri, 10 Oct 2025 21:05:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59AL5DqL043526; Fri, 10 Oct 2025 21:05:13 GMT (envelope-from git) Date: Fri, 10 Oct 2025 21:05:13 GMT Message-Id: <202510102105.59AL5DqL043526@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 5660178fd14b - stable/14 - Fix possible out of bounds read in armv8_crc32c List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 5660178fd14b9d45743231358f25dcbe801d090f Auto-Submitted: auto-generated The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=5660178fd14b9d45743231358f25dcbe801d090f commit 5660178fd14b9d45743231358f25dcbe801d090f Author: Zhongqi Zhao AuthorDate: 2025-09-10 14:21:38 +0000 Commit: John Baldwin CommitDate: 2025-10-10 21:00:12 +0000 Fix possible out of bounds read in armv8_crc32c Reviewed by: andrew Obtained from: CheriBSD Differential Revision: https://reviews.freebsd.org/D52401 (cherry picked from commit f48b1a34ef859ca17de0cc9149cc22e07364ef85) --- sys/libkern/arm64/crc32c_armv8.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/libkern/arm64/crc32c_armv8.S b/sys/libkern/arm64/crc32c_armv8.S index 649afff4b711..430b24f7615a 100644 --- a/sys/libkern/arm64/crc32c_armv8.S +++ b/sys/libkern/arm64/crc32c_armv8.S @@ -39,14 +39,14 @@ ENTRY(armv8_crc32c) cbz w2, end tbz x1, #0x0, half_word_aligned sub w2, w2, 0x1 - ldr w10, [x1], #0x1 + ldrb w10, [x1], #0x1 crc32cb w0, w0, w10 half_word_aligned: cmp w2, #0x2 b.lo last_byte tbz x1, #0x1, word_aligned sub w2, w2, 0x2 - ldr w10, [x1], #0x2 + ldrh w10, [x1], #0x2 crc32ch w0, w0, w10 word_aligned: cmp w2, #0x4 @@ -69,11 +69,11 @@ last_word: crc32cw w0, w0, w10 last_half_word: tbz w2, #0x1, last_byte - ldr w10, [x1], #0x2 + ldrh w10, [x1], #0x2 crc32ch w0, w0, w10 last_byte: tbz w2, #0x0, end - ldr w10, [x1], #0x1 + ldrb w10, [x1], #0x1 crc32cb w0, w0, w10 end: ret