From owner-freebsd-current@freebsd.org Fri Nov 6 01:08:33 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 81C1E2D6BB8 for ; Fri, 6 Nov 2020 01:08:33 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4CS2MP2PgSz3thT for ; Fri, 6 Nov 2020 01:08:33 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: by mailman.nyi.freebsd.org (Postfix) id 50D682D6BB7; Fri, 6 Nov 2020 01:08:33 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 506F12D6C31; Fri, 6 Nov 2020 01:08:33 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CS2MN4bQyz3tqs; Fri, 6 Nov 2020 01:08:32 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 0A618TiD072044 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 5 Nov 2020 17:08:29 -0800 (PST) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 0A618TeE072043; Thu, 5 Nov 2020 17:08:29 -0800 (PST) (envelope-from jmg) Date: Thu, 5 Nov 2020 17:08:29 -0800 From: John-Mark Gurney To: current@FreeBSD.org, ports@FreeBSD.org, imp@freebsd.org Subject: Re: DISTDIR name collision... Message-ID: <20201106010828.GA31099@funkthat.com> Mail-Followup-To: current@FreeBSD.org, ports@FreeBSD.org, imp@freebsd.org References: <20201106001347.GY31099@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201106001347.GY31099@funkthat.com> X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Thu, 05 Nov 2020 17:08:29 -0800 (PST) X-Rspamd-Queue-Id: 4CS2MN4bQyz3tqs X-Spamd-Bar: + X-Spamd-Result: default: False [1.52 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jmg]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; NEURAL_SPAM_SHORT(1.00)[0.998]; SPAMHAUS_ZRD(0.00)[208.87.223.18:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-0.38)[-0.377]; RBL_DBL_DONT_QUERY_IPS(0.00)[208.87.223.18:from]; R_SPF_NA(0.00)[no SPF record]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; MAILMAN_DEST(0.00)[current,ports]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 01:08:33 -0000 John-Mark Gurney wrote this message on Thu, Nov 05, 2020 at 16:13 -0800: > I just discovered that we have a variable name colission between the > FreeBSD base repo, and the ports tree. DISTDIR is used by the ports > repo for: > # DISTDIR - Where to search for and store copies of original sources > > But DISTDIR is also used by FreeBSD base for (from bsd.own.mk): > # DISTDIR Change the tree where the file for a distribution > # gets installed (see /usr/src/release/Makefile). [not set] > > except that it doesn't just get used in release/Makefile, it's used in > the base Makefile.inc1 for a number of things that I'm not entirely sure > what it's for. > > Can someone figure out what we should do in this case? > > This was discovered because ezjail-admin sets DISTDIR for ports, but it > was breaking my -DNO_ROOT installworld by putting the METALOG in an > incorrectly documented place (since fixed)... It was pointed out that there was a review already underway for this: https://reviews.freebsd.org/D26617 Can this just be tested by re, and committed? Thanks. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."