From owner-dev-commits-ports-main@freebsd.org Fri Jun 4 18:48:32 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 03FC96531F2; Fri, 4 Jun 2021 18:48:32 +0000 (UTC) (envelope-from tobias.kortkamp@gmail.com) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FxWxW6S8bz4c5H; Fri, 4 Jun 2021 18:48:31 +0000 (UTC) (envelope-from tobias.kortkamp@gmail.com) Received: by mail-ed1-f49.google.com with SMTP id ba2so10547957edb.2; Fri, 04 Jun 2021 11:48:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0vm5h58jE3TZCDYBYclMmUZDmL/g7xM6XLtUuClsHRY=; b=XreUJ7hy7W74uf2IWuHDmAmmQ/7LkjjaOrf0hEmKa1H4HMxj85JHc7L5U1rRgPmx/5 xAr1poB6c32fI3h4HY5qQidap6IkgMo/WQK+SvrWXSYtP86XY1DyMl3zSlfhJaxXyMrg cGc+I+kWaJ8JxnyhN+vBkRYKqObFkxj00W0yvXIFnIIltiOmkm39lLNqby34tgA16ncR e6CDgJDPYVkcAn3OODfNGXlYanhZt6d3CrwiyQd2W0IjgN/V2hLKw0v6yQkjUqnuBWVN QSRingIqCxh3b6+q+y89tKc7ffHV/6DvIpvIIRs4LaLEEoBZSYByRWhrOop01pp7CsLv E2wA== X-Gm-Message-State: AOAM53165WX8SGfztCt6ERVFYj64FoA2OYXG6Sx1vvhziYqMXFa6YzN4 dQMgd4SDpb+0sxZqZnPCi8mV77MRB1g= X-Google-Smtp-Source: ABdhPJzginCfeBeFUNQqfkdjeALcDLmnDzQX4MNns1ZSEH97E5NMgBhlgRLYT0Hbz8z/wzVp0nfh1A== X-Received: by 2002:aa7:dd98:: with SMTP id g24mr6209819edv.88.1622832510231; Fri, 04 Jun 2021 11:48:30 -0700 (PDT) Received: from urd.tobik.me (ip5f5ae253.dynamic.kabel-deutschland.de. [95.90.226.83]) by smtp.gmail.com with ESMTPSA id h2sm3177799edr.50.2021.06.04.11.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 11:48:29 -0700 (PDT) Date: Fri, 4 Jun 2021 20:49:34 +0200 From: Tobias Kortkamp To: Piotr Kubaj Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f75b9b72e5cb - main - games/fheroes2: look for libpng without suffix, switch to PORTDOCS Message-ID: References: <202106041251.154Cp68Z089802@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RWuTYbdMVOYqugqQ" Content-Disposition: inline In-Reply-To: <202106041251.154Cp68Z089802@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4FxWxW6S8bz4c5H X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2021 18:48:32 -0000 --RWuTYbdMVOYqugqQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 04, 2021 at 12:51:06PM +0000, Piotr Kubaj wrote: > The branch main has been updated by pkubaj: >=20 > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Df75b9b72e5cb7ac631cf10f9= 36d185ecd434ad72 >=20 > commit f75b9b72e5cb7ac631cf10f936d185ecd434ad72 > Author: Piotr Kubaj > AuthorDate: 2021-06-04 12:50:57 +0000 > Commit: Piotr Kubaj > CommitDate: 2021-06-04 12:50:57 +0000 >=20 > games/fheroes2: look for libpng without suffix, switch to PORTDOCS I think this is missing Reported by: danfe > -PLIST_FILES=3D bin/${PORTNAME} \ > - ${DOCSDIR}/README.txt \ > +PLIST_FILES=3D bin/${PORTNAME} > +PORTDOCS=3D ${DOCSDIR}/README.txt \ > ${DOCSDIR}/changelog.txt This won't work. Files in PORTDOCS are relative to ${DOSCDIR} so you need to drop ${DOCSDIR}/. Also PORTDOCS won't do anything without adding a DOCS option. $ make -C games/fheroes2 check-sanity /!\ fheroes2-0.9.4: Makefile errors /!\ PORTDOCS does not do anything unless the DOCS option is present. *** Error code 1 --RWuTYbdMVOYqugqQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAmC6dbxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2E48gf6A/NRay77IzqI89hAY59EELUxdu+ZrV3FhsAwGwTa2F/YEWc2JSE54b6F v3tXNghuFOy7Az6B37So7dI2YJhf+bgNnNbDig//Sb9f4CF/RabXN/sjkUncWO+8 3qABQnAwERSG9xxPfnPAifjexvhRa3QXud/j/5ZkEl5/uDHJmEM9WqTcScCge3KP 2H8G3Abshm7a+EmrpjDQndiUgqtsmR44+7B1FBYBEDW6W0rlv4yW533AsWGYbnV/ Z4LRG+PGX/WsO/oea8ZoVzh9D9qBDFlZ1wr6l9AxQvgJgiufPwr7aXmAu3r1bayd MND+xhEcHF4gSBSOtN7a/A703YSDYQ== =Dt7S -----END PGP SIGNATURE----- --RWuTYbdMVOYqugqQ--