Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 2 May 2020 09:17:57 +0000
From:      Rene Ladan <rene@freebsd.org>
To:        Warner Losh <imp@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r360540 - head/stand/libofw
Message-ID:  <20200502091757.GB16751@freefall.freebsd.org>
In-Reply-To: <20200502091635.GA16751@freefall.freebsd.org>
References:  <202005011750.041HoMaV058949@repo.freebsd.org> <20200502091635.GA16751@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 02, 2020 at 09:16:35AM +0000, Rene Ladan wrote:
> On Fri, May 01, 2020 at 05:50:22PM +0000, Warner Losh wrote:
> > Author: imp
> > Date: Fri May  1 17:50:21 2020
> > New Revision: 360540
> > URL: https://svnweb.freebsd.org/changeset/base/360540
> > 
> > Log:
> >   Remove more stray sparc64 ifdefs.
> >   
> >   Also, dmabuf appears to only be set for sparc64 case, but there was a
> >   comment at its only use that says it was broken for some apple
> >   adapters. #ifdef it all of that out now that nothing sets it.
> > 
> > Modified:
> >   head/stand/libofw/ofw_net.c
> > 
> > Modified: head/stand/libofw/ofw_net.c
> > ==============================================================================
> > --- head/stand/libofw/ofw_net.c	Fri May  1 17:17:01 2020	(r360539)
> > +++ head/stand/libofw/ofw_net.c	Fri May  1 17:50:21 2020	(r360540)
> [...]
> > @@ -220,20 +220,6 @@ ofwn_init(struct iodesc *desc, void *machdep_hint)
> >  #if defined(NETIF_DEBUG)
> >  	printf("ofwn_init: Open Firmware instance handle: %08x\n", netinstance);
> >  #endif
> > -
> > -#ifndef __sparc64__
>       ^
> Shouldn't this code always be present?

Ah yes, but already fixed :)

René



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200502091757.GB16751>