From owner-cvs-src@FreeBSD.ORG Tue Jan 30 23:36:35 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1BA4B16A403; Tue, 30 Jan 2007 23:36:35 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpout.mac.com (smtpout.mac.com [17.250.248.172]) by mx1.freebsd.org (Postfix) with ESMTP id 02F4313C49D; Tue, 30 Jan 2007 23:36:34 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from mac.com (smtpin07-en2 [10.13.10.152]) by smtpout.mac.com (Xserve/8.12.11/smtpout02/MantshX 4.0) with ESMTP id l0UNaYdr013752; Tue, 30 Jan 2007 15:36:34 -0800 (PST) Received: from [192.168.1.2] (c-67-164-11-148.hsd1.ca.comcast.net [67.164.11.148]) (authenticated bits=0) by mac.com (Xserve/smtpin07/MantshX 4.0) with ESMTP id l0UNaSWn018896 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 30 Jan 2007 15:36:33 -0800 (PST) In-Reply-To: <200701301246.l0UCk5xW042918@repoman.freebsd.org> References: <200701301246.l0UCk5xW042918@repoman.freebsd.org> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Tue, 30 Jan 2007 15:35:06 -0800 To: Max Laier X-Mailer: Apple Mail (2.752.3) X-Brightmail-Tracker: AAAAAA== X-Brightmail-scanned: yes Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_firmware.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2007 23:36:35 -0000 On Jan 30, 2007, at 4:46 AM, Max Laier wrote: > mlaier 2007-01-30 12:46:05 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/kern subr_firmware.c > Log: > MFC, subr_firmware.c 1.7: > In case we are supplied with an imagename that matches a > module, but not a > firmware in that module (eventhough this is a programming > error) - drop > the reference to the module again. > > Submitted by: Benjamin Close This breaks the tinderbox: TB --- 2007-01-30 22:41:29 - building generic kernel (COPTFLAGS=-O2 - pipe) TB --- 2007-01-30 22:41:29 - cd /home/marcel/tinderbox/pluto2/ RELENG_6/ia64/ia64/src TB --- 2007-01-30 22:41:29 - /usr/bin/make buildkernel KERNCONF=GENERIC >>> Kernel build for GENERIC started on Tue Jan 30 22:41:30 UTC 2007 >>> stage 1: configuring the kernel >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3.1: making dependencies >>> stage 3.2: building everything >>> [...] awk -f /q/scratch/marcel/tinderbox/RELENG_6/ia64/ia64/src/sys/modules/ firewire/sbp_targ/../../../conf/kmod_syms.awk sbp_targ.kld export_syms | xargs -J% objcopy % sbp_targ.kld ld -Bshareable -d -warn-common -o sbp_targ.ko.debug sbp_targ.kld objcopy --strip-debug sbp_targ.ko.debug sbp_targ.ko ===> firmware (all) cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE - nostdinc -I- -DHAVE_KERNEL_OPTION_HEADERS -include /q/scratch/ marcel/tinderbox/RELENG_6/ia64/ia64/obj/q/scratch/marcel/tinderbox/ RELENG_6/ia64/ia64/src/sys/GENERIC/opt_global.h -I. -I@ -I@/contrib/ altq -I@/../include -finline-limit=15000 -fno-common -g -I/q/scratch/ marcel/tinderbox/RELENG_6/ia64/ia64/obj/q/scratch/marcel/tinderbox/ RELENG_6/ia64/ia64/src/sys/GENERIC -ffixed-r13 -mfixed-range=f32-f127 -mno-sdata -ffreestanding -Wall -Wredundant-decls -Wnested-externs - Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline - Wcast-qual -fformat-extensions -std=c99 -c /q/scratch/marcel/ tinderbox/RELENG_6/ia64/ia64/src/sys/modules/firmware/../../kern/ subr_firmware.c /q/scratch/marcel/tinderbox/RELENG_6/ia64/ia64/src/sys/modules/ firmware/../../kern/subr_firmware.c: In function `firmware_get': /q/scratch/marcel/tinderbox/RELENG_6/ia64/ia64/src/sys/modules/ firmware/../../kern/subr_firmware.c:192: warning: implicit declaration of function `linker_release_module' /q/scratch/marcel/tinderbox/RELENG_6/ia64/ia64/src/sys/modules/ firmware/../../kern/subr_firmware.c:192: warning: nested extern declaration of `linker_release_module' *** Error code 1 Stop in /q/scratch/marcel/tinderbox/RELENG_6/ia64/ia64/src/sys/ modules/firmware. *** Error code 1 FYI, -- Marcel Moolenaar xcllnt@mac.com