From nobody Mon Mar 10 20:49:58 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZBTY272crz5pdgy; Mon, 10 Mar 2025 20:49:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZBTY25NFjz47D4; Mon, 10 Mar 2025 20:49:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741639798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sVbA2Uu6JaZxOCmwx6Q6+XLnl+Zp/q8peHsSmsWHiLw=; b=pZhmNug0CAdedeDct41PvwGKShrRyqAkG5tcljz4i4g6zLbZ7r+GbQX9PUnwPyEKiBWcdt l3ukpmdYnCcNaWWxnDJhvWyYNc7uGXFZNvIXN4WnzD1dHZ0tPY0bC0pn5P2GOeQPsXJnXl navoFYaxXEQr500pUHVjicR9p2AW8Kunfao1Jsx2Zi0tyRouEmH8Ng0iRk0jBBaIp9VUFE WE81vMaBmAn8XI/kopEc5fzTBUesccHWSWoZV40pMfdeMpu8UfKl32ALYOtXb1Cp/OTc54 2vafKufe+NoJ7nVJH1hRhP40fnq2tzPxZ9Vtw4GsB0Mocaq70peA0j/3uDdGEA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741639798; a=rsa-sha256; cv=none; b=YtYELeFT+qeRFu+w6hzUx+TCn9/jh6U9YAsl77RCBCo3kM6g0227htRV68etnlj1owjC4O JbP8eFAJa60v/we4iAUlze8E03XlTKKGIOTe3VHvhDkOh8pXKi5+TdBqyBPgyG7yyAEiTw zX8v+feQDUjtVf/ObZpMAA5YMB73RpF3yz1ub49p8c5WUvFLAqVRO+pCyQNxIHvkYz2cX3 w1rhaa0O6KYUoK6eLcqNmLcUCQNlC9Y1Q+aERNBXbo7IQD0k6Cm+sDFU+Y8jv/yGoB6GsL 2c/USD9kNwsgE1CQZl3yRtMIlicNken0dpEDFhwFabk7cx+BIQPp5I611sqtuQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741639798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sVbA2Uu6JaZxOCmwx6Q6+XLnl+Zp/q8peHsSmsWHiLw=; b=GmNqzoDGbxMlmXeXC/K+CxM3TFQZJGdYGxlkqZSY38iQkMo8BnPCsWXxt1VlYNQnGdDNFG ujvieNT4lZtcYRTax9y7YPP8ccpQpuG0g0tQUl2VRbNUm0AXkaDc5UnS+W2yNdkG7Rn5N3 z175SI1ZEwQRLIPwhMn24oypwwP7hQlz3Ees4UnvBveVpRuIdJBmNhBXIi/A/vfV+bRxO0 zbe38s0fHTxoXXoExL1uZKJlDrOro/Heq4W6TJLru2fdZ8Xi9DFQAWiMS4ksVdDR4IdWdx lHX+oxJV6YA0Fkdgd7IMXFHKURE+fudq8uptbA3HmkHd3UrWdYg7VlVfX6907w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZBTY24yb4zvS4; Mon, 10 Mar 2025 20:49:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52AKnwkF083722; Mon, 10 Mar 2025 20:49:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52AKnwg2083719; Mon, 10 Mar 2025 20:49:58 GMT (envelope-from git) Date: Mon, 10 Mar 2025 20:49:58 GMT Message-Id: <202503102049.52AKnwg2083719@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: ab95710f30f7 - main - sound: Make dev.pcm.X.mode dynamic List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ab95710f30f7255d3a6be22a1a2c375ee0f96868 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=ab95710f30f7255d3a6be22a1a2c375ee0f96868 commit ab95710f30f7255d3a6be22a1a2c375ee0f96868 Author: Christos Margiolis AuthorDate: 2025-03-10 20:47:39 +0000 Commit: Christos Margiolis CommitDate: 2025-03-10 20:47:39 +0000 sound: Make dev.pcm.X.mode dynamic Currently dev.pcm.X.mode is calculated only once in pcm_sysinit(), which is called by pcm_register() during attach, but this can result in inconsistencies. For some context, what pcm_mode_init() does is, it checks if "playcount" is positive, in which case we assume the device supports playback. The same is done for "reccount" for recording, and if "mixer_dev" is not NULL, we know the device has a mixer. The "playcount" and "reccount" variables correspond to the number of _primary_ playback/recording channels, so we can assume that the primary channels have been created before reaching pcm_mode_init(). However, for the mixer that's not always the case. If the mixer is created _after_ pcm_register(), as is the case for snd_dummy(4) for example, pcm_mode_init() will see that "mixer_dev" is NULL, and report that the device does not have a mixer, whereas in reality we just created it afterwards. While this could be fixed by simply creating the mixers always before pcm_register(), it is better to be robust and calculate the mode dynamically. Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D49024 --- sys/dev/sound/pcm/sound.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/sys/dev/sound/pcm/sound.c b/sys/dev/sound/pcm/sound.c index 5759c06725ce..c262a57ea5f1 100644 --- a/sys/dev/sound/pcm/sound.c +++ b/sys/dev/sound/pcm/sound.c @@ -322,28 +322,32 @@ sysctl_dev_pcm_bitperfect(SYSCTL_HANDLER_ARGS) return (err); } -static u_int8_t -pcm_mode_init(struct snddev_info *d) +static int +sysctl_dev_pcm_mode(SYSCTL_HANDLER_ARGS) { - u_int8_t mode = 0; + struct snddev_info *d; + int mode = 0; + d = oidp->oid_arg1; + if (!PCM_REGISTERED(d)) + return (ENODEV); + + PCM_LOCK(d); if (d->playcount > 0) mode |= PCM_MODE_PLAY; if (d->reccount > 0) mode |= PCM_MODE_REC; if (d->mixer_dev != NULL) mode |= PCM_MODE_MIXER; + PCM_UNLOCK(d); - return (mode); + return (sysctl_handle_int(oidp, &mode, 0, req)); } static void pcm_sysinit(device_t dev) { struct snddev_info *d = device_get_softc(dev); - u_int8_t mode; - - mode = pcm_mode_init(d); sysctl_ctx_init(&d->play_sysctl_ctx); d->play_sysctl_tree = SYSCTL_ADD_NODE(&d->play_sysctl_ctx, @@ -364,9 +368,10 @@ pcm_sysinit(device_t dev) "bitperfect", CTLTYPE_INT | CTLFLAG_RWTUN | CTLFLAG_MPSAFE, d, sizeof(d), sysctl_dev_pcm_bitperfect, "I", "bit-perfect playback/recording (0=disable, 1=enable)"); - SYSCTL_ADD_UINT(device_get_sysctl_ctx(dev), - SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), - OID_AUTO, "mode", CTLFLAG_RD, NULL, mode, + SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev), + SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), OID_AUTO, + "mode", CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_MPSAFE, d, sizeof(d), + sysctl_dev_pcm_mode, "I", "mode (1=mixer, 2=play, 4=rec. The values are OR'ed if more than " "one mode is supported)"); vchan_initsys(dev);