Date: Wed, 2 Mar 2005 13:21:02 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: hackers@freebsd.org Subject: truss bug + PATCH, pls review Message-ID: <20050302212102.GK11079@elvis.mu.org>
next in thread | raw e-mail | index | archive | help
Can someone review this? I think 'u' is incorrectly added to instead of assigned to. This causes the initial calculation to be garage based and screws up displaying poll information. I'd like this to be MFC'd before 5.4 if possible. Index: syscalls.c =================================================================== RCS file: /home/ncvs/src/usr.bin/truss/syscalls.c,v retrieving revision 1.45 diff -u -r1.45 syscalls.c --- syscalls.c 5 Sep 2004 05:27:30 -0000 1.45 +++ syscalls.c 2 Mar 2005 21:19:13 -0000 @@ -414,7 +414,7 @@ (POLLIN | POLLPRI | POLLOUT | POLLERR | POLLHUP | POLLNVAL | \ POLLRDNORM |POLLRDBAND | POLLWRBAND | POLLINIGNEOF) - u += snprintf(tmp + used, per_fd, + u = snprintf(tmp + used, per_fd, "%s%d 0x%hx%s%s%s%s%s%s%s%s%s ", i > 0 ? " " : "", pfd[i].fd, -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050302212102.GK11079>