From owner-svn-src-all@freebsd.org Fri Feb 3 20:48:57 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26B7FCCF5C1 for ; Fri, 3 Feb 2017 20:48:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E18DECBA for ; Fri, 3 Feb 2017 20:48:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x241.google.com with SMTP id e137so2771872itc.0 for ; Fri, 03 Feb 2017 12:48:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=5RyxMGoWjX6TlCVwAbLNDF+FG5pXSLEPzXkarUcTghY=; b=RuQZYvtPqlKyBknN7rZIlsdOLTbAOT9K7KPCFvnCxbzFh/TlWRrugMAMBjUl9Nivlr YP/RmbjdCGC1DqhcVTgHE1OQmkgHmPT+Ix/WqKIFxu/NAOEg3Jx/byl6HSSajj9d1N/K Fc1StqTyLhcbJTXOmP9p1ynbiHJ3qh0uRgEhmmOoJWUo6DGtdxlT5yajEe4xIYHf1nAX i6fep9OWKbdF+AeYhseJiiQjMePvqrqX3qmw3IrH7c5Zx4iJyuebcd/sriFSHhx8ApIn nFgtnrRABqHM0zNkvfAsrDkAK4sQf3QX9ACjyV8QZioPHj/DAauDKggK/gXO+6jp9Mv6 wqiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=5RyxMGoWjX6TlCVwAbLNDF+FG5pXSLEPzXkarUcTghY=; b=W3fXVdxGF10nAuH6Xufee3MffwYURoM0bE0GylYhSWXnzJp8GpEJ4QcriXGdfupQRb G05jXVxD7LrxHvv/1UA9IDwlw/7R3N2o9l3vHna6GvO+nVLUlmHeXZuLfCeV1ATwL1Ju 9zCbDIUmTBIOmBbSsqvXKqavlBNj+yRcQ6QQ7n/xK1lzTgauX726CWQFFAJM7rdS+PAo USIf7Q9MGplNxsp/0AMkO6K7PRsRDkkQtNKWBk6/Ijuaq0iKWlBhUbltndrzQmPWCeJU c+aKA2cVy34OmpkooJHNkj+qgQhr1kFOqMiR2Gs92d2/MFbpgYxEQxDH4eNb8zeNNU3S vV+g== X-Gm-Message-State: AIkVDXIiie2K4eiHCD3FuOd+OlFw0KsBMGbEgrYb086e2AIh1wJbZ24KRCzia2eRWXIgAPv+60wBXHCtUF4rvg== X-Received: by 10.36.93.213 with SMTP id w204mr2790486ita.60.1486154936234; Fri, 03 Feb 2017 12:48:56 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.145.217 with HTTP; Fri, 3 Feb 2017 12:48:55 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <1486154696.3017.201.camel@freebsd.org> References: <201702031639.v13GdAXQ074031@repo.freebsd.org> <1486140447.3017.189.camel@freebsd.org> <19994E26-42EE-4E12-9867-1E53FA2A7F81@me.com> <1486146017.3017.193.camel@freebsd.org> <1486154696.3017.201.camel@freebsd.org> From: Warner Losh Date: Fri, 3 Feb 2017 13:48:55 -0700 X-Google-Sender-Auth: TSI_To4bZNgaldyhQ93jzaSq4y0 Message-ID: Subject: Re: svn commit: r313166 - head/sys/boot/efi/libefi To: Ian Lepore Cc: Toomas Soome , Toomas Soome , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 20:48:57 -0000 On Fri, Feb 3, 2017 at 1:44 PM, Ian Lepore wrote: > On Fri, 2017-02-03 at 13:25 -0700, Warner Losh wrote: >> On Fri, Feb 3, 2017 at 11:20 AM, Ian Lepore wrote: >> > >> > On Fri, 2017-02-03 at 18:52 +0200, Toomas Soome wrote: >> > > >> > > > >> > > > >> > > > On 3. veebr 2017, at 18:47, Ian Lepore wrote: >> > > > >> > > > On Fri, 2017-02-03 at 16:39 +0000, Toomas Soome wrote: >> > > > > >> > > > > >> > > > > Author: tsoome >> > > > > Date: Fri Feb 3 16:39:10 2017 >> > > > > New Revision: 313166 >> > > > > URL: https://svnweb.freebsd.org/changeset/base/313166 >> > > > > >> > > > > Log: >> > > > > loader: libefi/env.c warnings in arm build >> > > > > >> > > > > The arm build has revealed some of the warnings, the fix >> > > > > for >> > > > > CHAR16 >> > > > > warning is to switch the warning off for env.c (same as for >> > > > > efinet.c). >> > > > > >> > > > How is disabling the warning instead of just fixing it the >> > > > right >> > > > thing >> > > > to do? I think disabling a printf format warning is never the >> > > > right >> > > > thing to do, it just turns a compile warning into a runtime >> > > > failure. >> > > I would love to see the correct fix - as all UEFI chars are 2 >> > > byte; >> > > but thats up to arm experts. I just do not know the details why >> > > the >> > > arm is stuck with 4 byte wchar_t there - Im sure they do not have >> > > this just for fun:) >> > > >> > > rgds, >> > > toomas >> > Hmm, looks like the right fix is to add -fshort-wchar to CFLAGS, >> > but >> > it's got to be consistant across all the libraries that get linked, >> > and >> > some of them are used in the non-efi case too. I'll have a closer >> > look >> > at whether we can fix it properly over the next few days. >> I just wonder why that isn't the default.... And the consistency >> matters only of wchar_t is used in the library... Lemme know what you >> come up with... >> >> Warner > > ARM's abi definition requires 4-byte wchar_t, but allows "certain > virtual environments" to use different sizes (without any explanation > about what that might mean or how to achieve it). > > I'm not sure about the "only matters if" part -- the linker was > spitting out hundreds of warnings about mismatched wchar_t sizes, as if > it were part of object file metadata that failed a sanity check or > something (or there are a lot more references to wchar_t in libstand > and libfdt than I would have imagined). Gotcha. I know the linker records various details in the .o's for sanity checking. Didn't think this was one of them, so, yea, it looks like you're right. We may have to build a separate copy of such libraries for UEFI since it has a different ABI. Warner