From owner-freebsd-audit Wed Mar 5 5:34:11 2003 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 020CE37B401; Wed, 5 Mar 2003 05:34:10 -0800 (PST) Received: from gw.nectar.cc (gw.nectar.cc [208.42.49.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B25743FCB; Wed, 5 Mar 2003 05:34:09 -0800 (PST) (envelope-from nectar@celabo.org) Received: from madman.celabo.org (madman.celabo.org [10.0.1.111]) by gw.nectar.cc (Postfix) with ESMTP id DF35038; Wed, 5 Mar 2003 07:34:08 -0600 (CST) Received: by madman.celabo.org (Postfix, from userid 1001) id C830D78C43; Wed, 5 Mar 2003 07:34:08 -0600 (CST) Date: Wed, 5 Mar 2003 07:34:08 -0600 From: "Jacques A. Vidrine" To: Sean Chittenden Cc: audit@FreeBSD.org Subject: Re: WARNS = 2, sbin/ping... Message-ID: <20030305133408.GE17270@madman.celabo.org> References: <20030209110853.GP15936@perrin.int.nxad.com> <20030305033902.GO79234@perrin.int.nxad.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030305033902.GO79234@perrin.int.nxad.com> X-Url: http://www.celabo.org/ User-Agent: Mutt/1.5.3i-ja.1 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Mar 04, 2003 at 07:39:02PM -0800, Sean Chittenden wrote: > > Speaking of WARNS2, here's a patch that bumps ping(8) to WARNS2. Once > > upon a tie it used to be WARNS5, but the patch has rotted some. The > > biggie in this one was collisions with sin(3) and sockaddr_in variable > > sin. -sc > > Follow up post. Does the WARNS=2 cleanup of ping look alright? A > slightly updated version of the patch is at the following URL: > > http://people.freebsd.org/~seanc/patches/#ping_warns_2 > > I've been using this for over a month and the patch above has been > updated to include recent IPSEC changes. -sc > It looks good to me, except for the string literal concatenation bit (but that's probably flamewar material anyway). Cheers, -- Jacques A. Vidrine http://www.celabo.org/ NTT/Verio SME . FreeBSD UNIX . Heimdal Kerberos jvidrine@verio.net . nectar@FreeBSD.org . nectar@kth.se To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message