From owner-freebsd-current@FreeBSD.ORG Mon Nov 22 14:53:40 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9DF8110656F0; Mon, 22 Nov 2010 14:53:40 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 6A6988FC16; Mon, 22 Nov 2010 14:53:40 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 17E6B46B03; Mon, 22 Nov 2010 09:53:40 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 35FCC8A01D; Mon, 22 Nov 2010 09:53:39 -0500 (EST) From: John Baldwin To: Andriy Gapon Date: Mon, 22 Nov 2010 09:30:23 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20101102; KDE/4.4.5; amd64; ; ) References: <4CE2771F.8020109@freebsd.org> <201011191158.19118.jhb@freebsd.org> <4CE79C42.6000103@freebsd.org> In-Reply-To: <4CE79C42.6000103@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201011220930.23179.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Mon, 22 Nov 2010 09:53:39 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: freebsd-current@freebsd.org, Pawel Jakub Dawidek Subject: Re: removing tq_name [Was: taskqueue_create() name parameter lieftime] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2010 14:53:40 -0000 On Saturday, November 20, 2010 5:00:34 am Andriy Gapon wrote: > on 19/11/2010 18:58 John Baldwin said the following: > > On Friday, November 19, 2010 11:20:04 am Andriy Gapon wrote: > >> BTW, tq_name doesn't seem to be used anywhere at all. > >> Perhaps just drop it? But still could be useful in a debugger, though. > > > > If it's not used anywhere I would just drop it. > > > > struct taskqueue is defined privately in sys/kern/subr_taskqueue.c and tq_name > is used "write-only" in _taskqueue_create(). > > So, no use for tq_name at all? No. Especially since the structure is private it can always be revived if a use is found for it. You can probably leave the taskqueue_create() API the same for now though. -- John Baldwin