From owner-svn-ports-all@freebsd.org  Wed Mar 13 15:53:02 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5AEA61537A96;
 Wed, 13 Mar 2019 15:53:02 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id ED17685B16;
 Wed, 13 Mar 2019 15:53:01 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id D530860DF; Wed, 13 Mar 2019 15:53:01 +0000 (UTC)
Date: Wed, 13 Mar 2019 15:53:01 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Diane Bruce <db@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r494945 - in head/comms/wsjtx: . files
Message-ID: <20190313155301.GA94270@FreeBSD.org>
References: <201903071345.x27Dj4Gv030049@repo.freebsd.org>
 <20190307135631.GA68662@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190307135631.GA68662@FreeBSD.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: ED17685B16
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.95 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.99)[-0.986,0];
 NEURAL_HAM_LONG(-1.00)[-0.997,0];
 NEURAL_HAM_SHORT(-0.97)[-0.966,0];
 ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Mar 2019 15:53:02 -0000

On Thu, Mar 07, 2019 at 01:56:31PM +0000, Alexey Dokuchaev wrote:
> On Thu, Mar 07, 2019 at 01:45:04PM +0000, Diane Bruce wrote:
> > New Revision: 494945
> > URL: https://svnweb.freebsd.org/changeset/ports/494945
> > 
> > Log:
> >   - update to 2.0.1
> >   - builds on i386 now
> >   - remove MAKE_JOBS_UNSAFE
> 
> When removing MAKE_JOBS_UNSAFE, it is expected to explain what was wrong
> before and why it is believed to be fixed now, otherwise the error might
> have simply not manifested itself.

See the example of how it's supposed to be handled in r495588.

> >     this updated port. The cmake build provided does not have an
> >     install/strip target which forces use of do-install.
> > ...
> > +do-install:
> > +	(cd ${CONFIGURE_WRKSRC};${MAKE} -f Makefile DESTDIR=${STAGEDIR} install)
> 
> This do-install target is very bogus (CONFIGURE_WRKSRC? ${MAKE}? whitespace
> bugs), but more importantly, why not patch CMakeLists.txt to provide a nice
> installation routine instead of this ugliness?

Any comment on this part?  I see it's still not fixed after almost a week.

./danfe