From owner-cvs-all Tue Apr 11 2:30:51 2000 Delivered-To: cvs-all@freebsd.org Received: from ms.tokyo.jcom.ne.jp (ms.tokyo.jcom.ne.jp [210.234.123.18]) by hub.freebsd.org (Postfix) with ESMTP id 8D38B37B9E3; Tue, 11 Apr 2000 02:30:43 -0700 (PDT) (envelope-from knu@idaemons.org) Received: from daemon.local.idaemons.org (pc343042.tokyo.jcom.ne.jp [203.140.143.42]) by ms.tokyo.jcom.ne.jp (8.9.1/3.7W 03/13/00) with ESMTP id SAA23146; Tue, 11 Apr 2000 18:30:38 +0900 (JST) Received: by daemon.local.idaemons.org (8.9.3/3.7W) id SAA78011; Tue, 11 Apr 2000 18:30:06 +0900 (JST) Date: Tue, 11 Apr 2000 18:30:06 +0900 Message-ID: <868zylrnmp.wl@archon.local.idaemons.org> From: "Akinori -Aki- MUSHA" To: asami@FreeBSD.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/chinese Makefile.inc ports/german Makefile.inc ports/japanese Makefile.inc ports/korean Makefile.inc ports/russian Makefile.inc ports/vietnamese Makefile.inc In-Reply-To: In your message of "11 Apr 2000 01:34:45 -0700" References: <200004101634.JAA94507@freefall.freebsd.org> <86hfd9rzkz.wl@archon.local.idaemons.org> <86d7nxrtbj.wl@archon.local.idaemons.org> User-Agent: Wanderlust/1.1.1 (Purple Rain) EMIKO/1.13.12 (Euglena sociabilis) FLIM/1.13.2 (Kasanui) APEL/10.2 MULE XEmacs/21.1 (patch 9) (Canyonlands) (i386--freebsd) Organization: Associated I. Daemons X-PGP-Public-Key: finger knu@FreeBSD.org X-PGP-Fingerprint: 1BEF D9B2 BABD 25D7 659A FD08 89C2 F3BE E981 4E16 MIME-Version: 1.0 (generated by EMIKO 1.13.12 - "Euglena sociabilis") Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG At 11 Apr 2000 01:34:45 -0700, Satoshi Asami wrote: > I don't think you need to go that far. How about the following? > Basically it includes ${.CURDIR}/../Makefile.inc iff ${.CURDIR} is > different from ${MASTERDIR} (i.e., this is a slave port). Ah, yes. That should work fine. I forgot MASTERDIR is always defined before including `bsd.port.mk'. In fact, I once did just the same as you did but wasn't sure that works right. :) > I also moved the PKGNAME/DISTNAME setting up to within the pre.mk > section, otherwise a port that tests on the value of PKGNAME will be > dead. Neat. That would help much. > (I only tested "make package-name", but since everything is > conditionalized on ${PKGNAME}, I think it will work.) I usually do `make -V variable' to check the value of the variable. You can check DISTNAME, for example, by doing `make -V DISTNAME'. :) And actually everything goes quite well here at present as I've been testing. > Note that you don't even have to set PORTNAME/PORTVERSION in ko-Wnn > anymore! Sure, I know what we're about. Now I just say "Go right ahead and commit them soon!" :) -- / /__ __ / ) ) ) ) / Akinori -Aki- MUSHA aka / (_ / ( (__( "If you choose not to decide you still have made a choice." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message