From owner-freebsd-current@freebsd.org Thu Jul 23 23:09:40 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D7C79A96C8 for ; Thu, 23 Jul 2015 23:09:40 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 1C1A71204 for ; Thu, 23 Jul 2015 23:09:40 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 18E049A96C7; Thu, 23 Jul 2015 23:09:40 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F347D9A96C6 for ; Thu, 23 Jul 2015 23:09:39 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wi0-x231.google.com (mail-wi0-x231.google.com [IPv6:2a00:1450:400c:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8C19D1203; Thu, 23 Jul 2015 23:09:39 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by wicgb10 with SMTP id gb10so4867019wic.1; Thu, 23 Jul 2015 16:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=RmVOEuMHjbsgIRx2SQc/FD1Uc/ihj+ExUhP2481uTmA=; b=VmLvRpxJarUY5qfajoE5AX8dfaYdGpW2zgQGJBANj1BY9bwlT0SOnQvKNzcdeSQvcA fun0M2gvPvyXOHBBryAIik/urc1xCfWLnv9XPNXGzohJcnSFRSGKyCokYqQA0eQPjzMv UAOvP5pv0AkUCRVkBcP7Bnr4GNFJuldJHiG0aK6Gz+Y0tnsRw8D5L13EEkWAohsnegnH n+6weyxgR2GImJIzRiECwO8Id3rMYOCIgZA41wYj/BXd/SsxbVHY9dX7umA0TdkYr6TX 7CE5bAAdqgQdfXIY/LbjuXcGtPcbzkymv7s91pr9BbgHezH2yGm146yQqac2uH2d0++G GKtA== X-Received: by 10.180.102.74 with SMTP id fm10mr1154842wib.25.1437692978082; Thu, 23 Jul 2015 16:09:38 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id fs8sm9672127wjb.7.2015.07.23.16.09.36 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 23 Jul 2015 16:09:36 -0700 (PDT) Date: Fri, 24 Jul 2015 01:09:34 +0200 From: Mateusz Guzik To: Sergey Kandaurov Cc: Don Lewis , current Subject: Re: null pointer dereference panic in cap_rights_contains() on 11.0-CURRENT r285785 amd64 Message-ID: <20150723230934.GA12297@dft-labs.eu> References: <201507232224.t6NMOPuX010901@gw.catspoiler.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 23:09:40 -0000 On Fri, Jul 24, 2015 at 02:07:17AM +0300, Sergey Kandaurov wrote: > On 24 July 2015 at 01:24, Don Lewis wrote: > > I just got this panic while using poudriere to build packages for > > FreeBSD 8.4 i386. > [..] > > db> bt > > Tracing pid 78211 tid 101405 td 0xfffff80139td29a0 > > cap_rights_contains() at cap_rights_contains+0x24/frame > > 0xfffffe005acc772d0 > > cap_check() at cap_check+0x15/frame 0xfffffe005acc7800 > > fget_unlocked() at fget_unlocked+0xca/frame 0xfffffe005acc7870 > > fget() at fget+0x2b/frame 0xfffffe005acc78a0 > > ksem_get at ksem_get+0x1e/frame 0xfffffe05acc78e0 > > sys_ksem_close() at sys_ksem_close+0x23/frame 0xfffffe005acc7920 > > ia32_syscall() at ia32_syscall+0x2a5/frame 0xfffffe005acc7a30 > > Xint0x00_syscall() at Xint0x00_syscall+0x95/frame 0xfffffe00acc7a30 > > --- syscall (400, FreeBSD ELF32, sys_ksem_close), rip = 0x2828676b, rsp > > = 0xffffc60c, rbp = 0xffffc628 --- > > > > > > Looks like this was missed after r284442. > > Index: kern/uipc_sem.c > =================================================================== > --- kern/uipc_sem.c (revision 285723) > +++ kern/uipc_sem.c (working copy) > @@ -651,12 +651,13 @@ > int > sys_ksem_close(struct thread *td, struct ksem_close_args *uap) > { > + cap_rights_t rights; > struct ksem *ks; > struct file *fp; > int error; > > /* No capability rights required to close a semaphore. */ > - error = ksem_get(td, uap->id, 0, &fp); > + error = ksem_get(td, uap->id, cap_rights_init(&rights), &fp); > if (error) > return (error); > ks = fp->f_data; > @@ -872,12 +873,13 @@ > int > sys_ksem_destroy(struct thread *td, struct ksem_destroy_args *uap) > { > + cap_rights_t rights; > struct file *fp; > struct ksem *ks; > int error; > > /* No capability rights required to close a semaphore. */ > - error = ksem_get(td, uap->id, 0, &fp); > + error = ksem_get(td, uap->id, cap_rights_init(&rights), &fp); > if (error) > return (error); > ks = fp->f_data; > > Correct, please commit. -- Mateusz Guzik