From owner-freebsd-audit Sun Feb 9 5:31: 2 2003 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0021237B401; Sun, 9 Feb 2003 05:31:01 -0800 (PST) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E53743FAF; Sun, 9 Feb 2003 05:31:01 -0800 (PST) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 7C5A4536E; Sun, 9 Feb 2003 14:30:58 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Sean Chittenden Cc: audit@FreeBSD.org Subject: Re: WARNS = 2, sbin/ping... From: Dag-Erling Smorgrav Date: Sun, 09 Feb 2003 14:30:58 +0100 In-Reply-To: <20030209110853.GP15936@perrin.int.nxad.com> (Sean Chittenden's message of "Sun, 9 Feb 2003 03:08:53 -0800") Message-ID: User-Agent: Gnus/5.090014 (Oort Gnus v0.14) Emacs/21.2 (i386--freebsd) References: <20030209110853.GP15936@perrin.int.nxad.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Sean Chittenden writes: > Speaking of WARNS2, here's a patch that bumps ping(8) to WARNS2. Once > upon a tie it used to be WARNS5, but the patch has rotted some. The > biggie in this one was collisions with sin(3) and sockaddr_in variable > sin. That's a compiler bug (unless is in scope). The correct solution is not to rename the variable, but to add -fno-builtin to CFLAGS globally, and fix those parts of the tree that break due to missing includes. Who knows, we might even uncover libc bugs that have been hitherto been masked by the compiler. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message