From owner-freebsd-python@freebsd.org Wed Jan 15 00:34:18 2020 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4E0331F9E44 for ; Wed, 15 Jan 2020 00:34:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 47y7cV1SvVz3KqX for ; Wed, 15 Jan 2020 00:34:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3094A1F9E43; Wed, 15 Jan 2020 00:34:18 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 305901F9E42 for ; Wed, 15 Jan 2020 00:34:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47y7cV0Y3Fz3KqW for ; Wed, 15 Jan 2020 00:34:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0E3B5261AC for ; Wed, 15 Jan 2020 00:34:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00F0YGco027470 for ; Wed, 15 Jan 2020 00:34:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00F0YGfl027468 for python@FreeBSD.org; Wed, 15 Jan 2020 00:34:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 243358] lang/python*: DISABLED_EXTENSIONS doesn't work as advertised Date: Wed, 15 Jan 2020 00:33:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2020 00:34:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243358 --- Comment #1 from Enji Cooper --- I take it back. My REINPLACE_CMD was wrong. This works: $ git diff ports/lang/ diff --git a/ports/lang/python38/Makefile b/ports/lang/python38/Makefile index 3bdf1c461846..968cd2b167f5 100644 --- a/ports/lang/python38/Makefile +++ b/ports/lang/python38/Makefile @@ -34,9 +34,9 @@ PYTHON_SUFFIX=3D ${PYTHON_VER:S/.//g} DISABLED_EXTENSIONS=3D _sqlite3 _tkinter _gdbm CONFIGURE_ARGS+=3D --enable-shared --without-ensurepip -CONFIGURE_ENV+=3D OPT=3D"" DISABLED_EXTENSIONS=3D"${DISABLED_EXTENSIONS}" # Null out OPT to respec= t user CFLAGS and remove optimizations +CONFIGURE_ENV+=3D OPT=3D""=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20 # Null out OPT to respect user CFLAGS and remove optimizations -INSTALL_TARGET=3D altinstall=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20 # Don't want cloberring of unprefixed files +INSTALL_TARGET=3D altinstall=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20 # Don't want clobbering of unprefixed files TEST_TARGET=3D buildbottest TEST_ARGS=3D TESTOPTS=3D-j${MAKE_JOBS_NUMBER} @@ -132,6 +132,10 @@ post-patch: # which introduces hidden dependency and breaks build @${REINPLACE_CMD} -e 's|uuid/uuid.h|ignore_&|' ${WRKSRC}/configure @${REINPLACE_CMD} -e '/find_library_file/ s|uuid|ignore_&|' ${WRKSRC}/setup.py +.if !empty(DISABLED_EXTENSIONS) + @${REINPLACE_CMD} -e '/^#\*disabled\*/ s|^#||' ${WRKSRC}/Modules/Se= tup + @${ECHO_CMD} "${DISABLED_EXTENSIONS}" >> ${WRKSRC}/Modules/Setup +.endif post-install: .if ! ${PORT_OPTIONS:MDEBUG} --=20 You are receiving this mail because: You are the assignee for the bug.=