Date: Fri, 15 Dec 2023 12:00:48 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Rainer Hurling <rhurlin@FreeBSD.org> Cc: "<tagattie@freebsd.org>" <tagattie@freebsd.org>, FreeBSD Mailing List <freebsd-ports@freebsd.org> Subject: Re: devel/electron25: Build failure on CURRENT with clang17 Message-ID: <54FE2DC5-3921-4506-A74A-C405675C4660@FreeBSD.org> In-Reply-To: <58389025-d360-4d62-af97-09c66699d42a@gwdg.de> References: <e26a34ef-ad6d-4a42-872f-2a1b33c6973c@gwdg.de> <3A903343-1A21-474D-82A2-ACE40DCE19D3@FreeBSD.org> <CF051A2F-C800-4DC7-8AE9-91407F3AB504@FreeBSD.org> <39cb099e-73cb-4532-8b2d-a10be1487a12@gwdg.de> <58389025-d360-4d62-af97-09c66699d42a@gwdg.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 Dec 2023, at 11:52, Rainer Hurling <rhurlin@gwdg.de> wrote: >=20 > Am 15.12.23 um 06:39 schrieb Rainer Hurling: >> Am 15.12.23 um 00:53 schrieb Dimitry Andric: >>> On 14 Dec 2023, at 21:23, Dimitry Andric <dim@FreeBSD.org> wrote: >>>>=20 >>>> On 14 Dec 2023, at 20:49, Rainer Hurling <rhurlin@gwdg.de> wrote: ... >>>>> ../../base/containers/checked_iterators.h:248:8: error: no = template named '__is_cpp17_contiguous_iterator'; did you mean = '__libcpp_is_contiguous_iterator'? >>>>> 248 | struct = __is_cpp17_contiguous_iterator<::base::CheckedContiguousIterator<T>> >>>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>> | __libcpp_is_contiguous_iterator ... >>> I haven't yet been able to build the port itself as my test machine = is >>> swamped with jobs, but the patch from qt6-webengine applied without >>> fuzz. Can you please try the attached diff? ... > The build and installation are ok, the updated electron25 seems = usable, tested by updating editors/vscode :D >=20 > Attached you will find the almost same patch, but in the naming = convention of ports, derived by 'make makepatch'. Strange, my original patch was also produced by make makepatch. :) > BTW, do we also have to patch other electon versions? I'm not sure. The fix is actually from upstream chromium, so if newer electron versions are based off of a "new enough" chromium snapshot, they should have it. I will take a look at the sources, because building these ports is pretty awful: [ 6% 2757/45534] after about an hour. :P -Dimitry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54FE2DC5-3921-4506-A74A-C405675C4660>