From owner-cvs-src@FreeBSD.ORG Mon Aug 16 03:49:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4AC3116A4CF; Mon, 16 Aug 2004 03:49:52 +0000 (GMT) Received: from smtp3.server.rpi.edu (smtp3.server.rpi.edu [128.113.2.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC37243D2F; Mon, 16 Aug 2004 03:49:51 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp3.server.rpi.edu (8.13.0/8.13.0) with ESMTP id i7G3nnor027801; Sun, 15 Aug 2004 23:49:50 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20040816031820.GA980@green.homeunix.org> References: <200408150624.i7F6OhhR074096@repoman.freebsd.org> <20040816014244.GB3026@green.homeunix.org> <20040816015108.GQ991@funkthat.com> <20040816023851.GC3026@green.homeunix.org> <20040816031820.GA980@green.homeunix.org> Date: Sun, 15 Aug 2004 23:49:47 -0400 To: Brian Fundakowski Feldman , bde@FreeBSD.org From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: John-Mark Gurney cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_target.c src/sys/dev/mii mii.c src/sys/fs/fifofs fifo_vnops.c src/sys/gnu/ext2fs ext2_vnops.c src/sys/kern init_main.c kern_conf.c kern_descrip.c kern_event.c kern_exec.c kern_exit.c kern_fork.c kern_sig.c sys_pipe.c tty.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2004 03:49:52 -0000 At 11:18 PM -0400 8/15/04, Brian Fundakowski Feldman wrote: >On Sun, Aug 15, 2004, Garance A Drosihn wrote: > > >> In some cases, such as this one, you are removing a blank line >> which style(9) wants to have there. ISTR being told that if there >> are no local variables in a routine, there should be a blank line >> before the first executable statement. Looking at the man page, I >> think that is shown by the example: >> >> static void >> usage() >> { >> /* Insert an empty line if the function has no local variables. */ > >That example actually shows there being a non-empty line where variable >declaration would have been... I never knew exactly what to make of it. Yeah, the rule doesn't exactly jump out at you from the man page. I just remember being asked to add the blank lines if there were no local variables, so I always add them... -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu