From owner-freebsd-ports-bugs@freebsd.org Sat Mar 5 16:38:21 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8FD5CA097C5 for ; Sat, 5 Mar 2016 16:38:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 80EC48BC for ; Sat, 5 Mar 2016 16:38:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u25GcLHo058409 for ; Sat, 5 Mar 2016 16:38:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 207657] games/fairymax: Update to 5.0b Date: Sat, 05 Mar 2016 16:38:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch, patch-ready X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rakuco@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Mar 2016 16:38:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207657 Raphael Kubo da Costa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakuco@FreeBSD.org --- Comment #4 from Raphael Kubo da Costa --- Hi Kalten, I have some suggestions for your update: - share/games/plugins looks like a very generic directory for fairymax to u= se. How about setting |plugindir| to ${DATADIR}/plugins in MAKE_ARGS. - INI_Q already seems to be set to ${DATADIR}/qmax.ini since you set fairyd= ir to ${DATADIR}, so I guess you don't need to explicitly set it. - "-O2" doesn't really justify having an OPTIMIZED_CFLAGS option. It's pass= ed by default by the ports tree along with "-pipe -fstack-protector -fno-strict-aliasing". - The fairymax.pod sed call doesn't seem to be replacing anything in this version. - fairymax's Makefile already has an install target, do you really need to = have a custom do-install target yourself? --=20 You are receiving this mail because: You are the assignee for the bug.=