From owner-cvs-src-old@FreeBSD.ORG Wed Jan 21 06:55:38 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1194106564A for ; Wed, 21 Jan 2009 06:55:38 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9C4168FC0C for ; Wed, 21 Jan 2009 06:55:38 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n0L6tcL9043060 for ; Wed, 21 Jan 2009 06:55:38 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n0L6tcUP043059 for cvs-src-old@freebsd.org; Wed, 21 Jan 2009 06:55:38 GMT (envelope-from kientzle@repoman.freebsd.org) Message-Id: <200901210655.n0L6tcUP043059@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to kientzle@repoman.freebsd.org using -f From: Tim Kientzle Date: Wed, 21 Jan 2009 06:55:27 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_write_disk.c src/lib/libarchive/test Makefile test_write_disk_failures.c test_write_disk_secure.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2009 06:55:39 -0000 kientzle 2009-01-21 06:55:27 UTC FreeBSD src repository Modified files: lib/libarchive archive_write_disk.c lib/libarchive/test Makefile test_write_disk_secure.c Added files: lib/libarchive/test test_write_disk_failures.c Log: SVN rev 187521 on 2009-01-21 06:55:27Z by kientzle Merge-from-Googlecode r419 In archive_write_disk: If archive_write_header() fails to create the file, that's a failure and should return ARCHIVE_FAILED. Metadata restore failures still return ARCHIVE_WARN, because that's non-critical. Fix test_write_disk_secure test to verify the correct return code in one case; add test_write_disk_failures to do another very simple test of restore failure. This should fix cpio coredumping when it tries to restore to a write-protected directory. Thanks to: Giorgos Keramidas MFC after: 30 days Revision Changes Path 1.43 +17 -17 src/lib/libarchive/archive_write_disk.c 1.30 +1 -0 src/lib/libarchive/test/Makefile 1.1 +62 -0 src/lib/libarchive/test/test_write_disk_failures.c (new) 1.9 +1 -1 src/lib/libarchive/test/test_write_disk_secure.c