Date: Sun, 13 May 2001 08:54:50 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Ian Dowse <iedowse@maths.tcd.ie> Cc: freebsd-fs@freebsd.org Subject: Re: vflush() Message-ID: <5153.989736890@critter> In-Reply-To: Your message of "Fri, 11 May 2001 22:19:00 BST." <200105112219.aa94946@salmon.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200105112219.aa94946@salmon.maths.tcd.ie>, Ian Dowse writes: >In message <200105092238.aa48273@salmon.maths.tcd.ie>, Ian Dowse writes: >> >>All this suggests that vflush() should subsume the logic for dealing >>with the reference count on the filesystem root vnode. This would >>simplify the xxx_umount() functions and permits the FORCECLOSE >>problem to be solved for all 9 filesystems in one place. > >A working version of a patch that achieves this is at: > > http://www.maths.tcd.ie/~iedowse/FreeBSD/vflush_patch Looks good to me. >As a side-effect, this corrects a vnode leak that currently exists >in devfs, as there was a vput() missing for the case where vflush() >failed. This bug could result in idle devfs filesystems that refuse >to unmount. oops... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5153.989736890>