From owner-svn-src-all@freebsd.org Thu May 24 15:57:48 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDD2FEF62D5; Thu, 24 May 2018 15:57:48 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6B9C474727; Thu, 24 May 2018 15:57:48 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-io0-f171.google.com (mail-io0-f171.google.com [209.85.223.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 36DD91200E; Thu, 24 May 2018 15:57:48 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-io0-f171.google.com with SMTP id g1-v6so2899382iob.2; Thu, 24 May 2018 08:57:48 -0700 (PDT) X-Gm-Message-State: ALKqPweYAGbiJ0CwOSDmhuSvM7618CYoA71lT88ptdYUdGqnGB8ceO+h ZifvmAEeYrk+0e+XZMtm8H3AeNa6AKMrv/Rmm+U= X-Google-Smtp-Source: ADUXVKI6HaHKcyZeEwbjMrKQdk0H11DS+hd4omXclQ683P1FGenDAVrSbT0D9aEUVhzplPn3h3nP3rCDr35c3/7pBWA= X-Received: by 2002:a6b:6707:: with SMTP id b7-v6mr2053668ioc.132.1527177467432; Thu, 24 May 2018 08:57:47 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:85ca:0:0:0:0:0 with HTTP; Thu, 24 May 2018 08:57:46 -0700 (PDT) In-Reply-To: References: <201805190510.w4J5AqfS054367@repo.freebsd.org> <20180523222743.GU71675@FreeBSD.org> <20180523225729.GV71675@FreeBSD.org> <20180524044252.GW71675@FreeBSD.org> <5B9EE208-384F-44AD-9B47-059D77FE9B34@macmic.franken.de> From: Matthew Macy Date: Thu, 24 May 2018 08:57:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r333860 - head/sys/kern To: Warner Losh Cc: Michael Tuexen , Gleb Smirnoff , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 15:57:48 -0000 On Thu, May 24, 2018 at 8:54 AM, Warner Losh wrote: > > > On Thu, May 24, 2018 at 12:36 AM, Matthew Macy wrote: >> >> On Wed, May 23, 2018 at 11:35 PM, Michael Tuexen >> wrote: >> >> On 24. May 2018, at 06:51, Matthew Macy wrote: >> >> >> >> Warnings find bugs PERIOD. Although most are not useful, I've found >> > Some warnings indicate bugs, some warnings are just wrong. If you >> > have a "may be used uninitialized" warning being a false positive, you >> > may silences the warning by just set it to zero in the declaration and >> > you silence it. Other compilers might then correctly report an >> > assignment without affect... >> >> I have yet to see a double assignment be flagged as assignment without >> effect. If it _does_ occur then we have to disable the warning on the >> compiler that we have less faith in. > > > Coverity does exactly that. :-(