From owner-freebsd-usb@FreeBSD.ORG Tue Feb 17 05:43:47 2009 Return-Path: Delivered-To: usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 18E1D106567F for ; Tue, 17 Feb 2009 05:43:47 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.226]) by mx1.freebsd.org (Postfix) with ESMTP id D789A8FC17 for ; Tue, 17 Feb 2009 05:43:46 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: by rv-out-0506.google.com with SMTP id f6so2050679rvb.43 for ; Mon, 16 Feb 2009 21:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent:organization :x-operation-sytem; bh=ivKq+OSPLR7L7Y7bQQHsAT2aGq4MAi4gP1CWOMUSEU8=; b=jYvrckQJyiJ232AcIpfI2bO7sJZngBjflcf6p8p4QfgWDKtA2eHzhvOw+zrsargR2Z ydmKR2Y3vQdRDTkiMtQCeMZORQzhCZu0ihax/C6Z0wuIoTP2dXyGusp3pugJb1GSzFog J2l7WXKYV0DG0zlZ+6nDVHOamGQ/Gd+Fxp2rc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :organization:x-operation-sytem; b=UTZP3SMyRHRwoVCrihzdg2wDrwlgOwxDhTpZHkEAKl10XGDe0ckwB630TPxWsWjKu8 yeyp3ecaGoxXf0R/0yCO6ISgeL7iohdvePBrUU3rrp5pkfMlOmuQc7PeFBw+f5fKzQd7 IIs0UtMQ9OTKmML2RHgeyIamqr7lH20Stv6EQ= Received: by 10.141.97.5 with SMTP id z5mr681956rvl.212.1234848101697; Mon, 16 Feb 2009 21:21:41 -0800 (PST) Received: from weongyo ([114.111.62.249]) by mx.google.com with ESMTPS id g22sm5629552rvb.0.2009.02.16.21.21.39 (version=SSLv3 cipher=RC4-MD5); Mon, 16 Feb 2009 21:21:40 -0800 (PST) Received: by weongyo (sSMTP sendmail emulation); Tue, 17 Feb 2009 14:21:21 +0900 From: Weongyo Jeong Date: Tue, 17 Feb 2009 14:21:21 +0900 To: Robert Watson Message-ID: <20090217052121.GB86244@weongyo.cdnetworks.kr> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Organization: CDNetworks. X-Operation-Sytem: FreeBSD Cc: usb@freebsd.org, Hans Petter Selasky , thompsa@freebsd.org Subject: Re: USB support in NDIS -- IFF_NEEDSGIANT? X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Weongyo Jeong List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2009 05:43:47 -0000 On Mon, Feb 16, 2009 at 11:33:18AM +0000, Robert Watson wrote: > > Dear all: > > As you know, I've been gradually working to eliminate all non-MPSAFE > network device driver infrastructure for 8.0, having removed non-MPSAFE > network protocol infrastructure in 7.0. In reviewing remaining drivers > using IFF_NEEDSGIANT, I spotted this in the NDIS code: > > 718 if_initname(ifp, device_get_name(dev), device_get_unit(dev)); > 719 ifp->if_mtu = ETHERMTU; > 720 ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST; > 721 if (sc->ndis_iftype == PNPBus) > 722 ifp->if_flags |= IFF_NEEDSGIANT; > 723 ifp->if_ioctl = ndis_ioctl; > 724 ifp->if_start = ndis_start; > 725 ifp->if_init = ndis_init; > > Having taken a glance, it looks like this was added specifically to support > USB devices attached via NDIS. AFAIK all of usb wireless drivers had it so I couldn't avoid it when I had implemented. > With the new USB code, are NDIS drivers still supported? I think that it would be supported at 8.0 > And in the new world order, is this IFF_NEEDSGIANT still required? Probably we can remove the IFF_NEEDSGIANT flags at the new USB code. > Can I simply remove it once the old USB code is on the way out the > door? IMHO yes I think. > (Note that the plan is to remove all device drivers that still require > IFF_NEEDSGIANT some time before 8.0, probably starting with disabling them > from the build in about 2-3 weeks). regards, Weongyo Jeong