From owner-freebsd-python@FreeBSD.ORG Wed Sep 7 09:03:04 2011 Return-Path: Delivered-To: freebsd-python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8E9C4106564A for ; Wed, 7 Sep 2011 09:03:04 +0000 (UTC) (envelope-from sbrabez@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 1E8C38FC08 for ; Wed, 7 Sep 2011 09:03:03 +0000 (UTC) Received: by wyh15 with SMTP id 15so6557945wyh.13 for ; Wed, 07 Sep 2011 02:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=hMJlvxlzT2Ao58ros9ASIpNQ3VqPKaTpZgwPi8F1aIc=; b=pnyFoTC7BsuPlWzvczqDixKNiuOe4kqTL3N4HZhJBypfMRuTAOtqk3v5yltfP11FNK y9i56uYs2Njie0+z4i/BZ9LVyYBGHOgJnsoTw9xlbyBj1gz3n4nDAjzbqZ6pjva7Dep6 T7TMhosMO+4HMjWb/zEuY0antq8/NfKSpKaGQ= Received: by 10.216.14.234 with SMTP id d84mr4405523wed.85.1315386182095; Wed, 07 Sep 2011 02:03:02 -0700 (PDT) Received: from freebsd.ifr.lan (paris.office.wallix.com [82.238.42.70]) by mx.google.com with ESMTPS id fr18sm2928206wbb.9.2011.09.07.02.02.59 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 07 Sep 2011 02:03:00 -0700 (PDT) Sender: Sofian Brabez Date: Wed, 7 Sep 2011 13:02:55 +0200 From: Sofian Brabez To: Li-Wen Hsu Message-ID: <20110907110255.GA1795@freebsd.ifr.lan> References: <20110906205704.GA38513@freebsd.ifr.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pf9I7BMVVzbSWLtt" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: FreeBSD Python Team Subject: Re: Update of devel/py-twisted to 11.0.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2011 09:03:04 -0000 --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi python@, On Wed, Sep 07, 2011 at 02:02:43PM +0800, Li-Wen Hsu wrote: > Hello Sofian, >=20 > Thanks for working on this, python@ definitely need more power! >=20 > Please see the reply inline. >=20 > On Wed, Sep 7, 2011 at 04:57, Sofian Brabez wrote: > > Hi python@, > > > > This afternoon, I've merged my initial update to the twisted related po= rts with > > the patch of lwhsu@ [1]. My patch is there [2]. > > > > My patch make happy portlint, add LICENSE in each twisted ports and add= new > > OPTIONS for twistedPair port. >=20 > And please also add pair_DEPENDS in bsd.python.mk, that is around line 64= 1. Done >=20 > > Please lwhsu@ notice than all twisted ports are sharing the > > ${PYTHON_SITELIBDIR}/twisted/plugins folder that's why I've replaced th= e @dirrm > > by a @dirrmtry in pkg-plist. >=20 > Thanks for reminding me this, I think we have >=20 > @dirrm %%PYTHON_SITELIBDIR%%/twisted/plugins in >=20 > in devel/py-twistedCore/pkg-plist, and all other twisted ports depends > on twistedCore, so we probably don't need to have @dirrm nor @dirrmtry > in other ports. > They sneaked in my patch because I forget this, so just removing them > is fine. (I was planning getting maintainer's approval on general idea > then doing a more substantial patch.) > Using @dirrmtry is fine, too. >=20 Imho, we should keep the @dirrmtry directive to remember us that all twisted ports install files in ${PYTHON_SITELIBDIR}/twisted/plugins and agreed the = only @dirrm should be in devel/py-twistedCore/pkg-plist file. > > I would like to have your approbation to commit it, and sent it to my m= entors > > for their approbations, I start working on this one because I took the = pr > > ports/155570 but lwhsu@ inform me about ports/159954 on #freebsd-python. > > > > Below the tinderbox build logs: > > > > http://regis.goodking.org/tb/index.php?action=3Dlist_buildports&build= =3D7-sbz&search_port_name=3Dtwisted&Go=3DGo > > http://regis.goodking.org/tb/index.php?action=3Dlist_buildports&build= =3D8-sbz&search_port_name=3Dtwisted&Go=3DGo > > http://regis.goodking.org/tb/index.php?action=3Dlist_buildports&build= =3D9-sbz&search_port_name=3Dtwisted&Go=3DGo >=20 > All looks good, and I also tested building all other ports depends on > twisted, all are fine. Is anybody aware non-backward-compatible > change? >=20 > Another thing, I found there is no twisted 11.0.0 distfiles in > http://tmrc.mit.edu/mirror/twisted/, that's why I removed them from > MASTER_SITES, could you check it again? Indeed, I remove them, we will see in the future if they remirrored them. >=20 > Please consider my suggestions, thanks! >=20 Patch update with your suggestions, now I'm waiting your go ;), I save the = old version [1] and the new [2] there. > > Regards > > > > [1] http://people.freebsd.org/~lwhsu/twisted-11.0.0.diff > > [2] http://people.freebsd.org/~sbz/twisted-11.0.0.diff > > > > -- > > Sofian Brabez > > >=20 >=20 >=20 > --=20 > Li-Wen Hsu > http://lwhsu.org Regards [1] http://people.freebsd.org/~sbz/twisted-11.0.0.old.diff [2] http://people.freebsd.org/~sbz/twisted-11.0.0.diff -- Sofian Brabez --pf9I7BMVVzbSWLtt Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk5nT14ACgkQc2NR9CSH5X7RagCfU86NDN1oOf50kev13JUk2q1z +o4AoMKTKlh6KtrJtmAjVAdJMN7pgWiM =AFkl -----END PGP SIGNATURE----- --pf9I7BMVVzbSWLtt--