From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Feb 27 14:00:41 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BCDE516A4DB for ; Fri, 27 Feb 2004 14:00:41 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B778243D2D for ; Fri, 27 Feb 2004 14:00:41 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i1RM0fbv058893 for ; Fri, 27 Feb 2004 14:00:41 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i1RM0fTh058892; Fri, 27 Feb 2004 14:00:41 -0800 (PST) (envelope-from gnats) Date: Fri, 27 Feb 2004 14:00:41 -0800 (PST) Message-Id: <200402272200.i1RM0fTh058892@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Oliver Eikemeier Subject: Re: ports/63059: linux-flashplugin LATEST_LINK and RESTRICTED fixes X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Oliver Eikemeier List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2004 22:00:41 -0000 The following reply was made to PR ports/63059; it has been noted by GNATS. From: Oliver Eikemeier To: "Brandon D. Valentine" Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/63059: linux-flashplugin LATEST_LINK and RESTRICTED fixes Date: Fri, 27 Feb 2004 22:51:02 +0100 Brandon D. Valentine wrote: > On Thu, Feb 26, 2004 at 01:31:36AM +0100, Oliver Eikemeier wrote: > >>Ok, I understand what should be done here. May I make two suggestions: > > Thanks for reviewing this, Oliver. You are welcome. Thanks for your explanations. >>- it would be nice to have the link creation in a pkg-install script, >> since the autodetection fails if the port is installed from a package > > The port sets NO_PACKAGE and RESTRICTED. Do I still need to worry about > pkg-install time? =) Maybe. Users might decide to build packages locally (eg to update multiple machines, like a lab). >>- a more-or-less short comment what would be removed and why wouldn't be >>bad, >> (especially because this may remove symlinks not created by the port). >> I'm not sure where to place this comments, though. Perhaps the pkg-install >> script where the links are created is a good place. > > I'm not sure where the best place to put this is either. Should I just > put a comment in the Makefile or do I need to print a warning to the > user at install time? No, I guess users aren't really interested. It's more stupid committers asking the same stupid questions over & over again. Maybe you want to include some of this in the next revision. Oliver