From owner-freebsd-current@FreeBSD.ORG Wed Jan 7 01:25:07 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86DB91065677 for ; Wed, 7 Jan 2009 01:25:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 3EA598FC18 for ; Wed, 7 Jan 2009 01:25:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 8A98241C613; Wed, 7 Jan 2009 02:25:05 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id JJpXpByURCnp; Wed, 7 Jan 2009 02:25:05 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id 226D241C5DC; Wed, 7 Jan 2009 02:25:05 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 018904448DD; Wed, 7 Jan 2009 01:22:39 +0000 (UTC) Date: Wed, 7 Jan 2009 01:22:39 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Andrzej Tobola In-Reply-To: <20081216053058.GA37217@amp2.iem.pw.edu.pl> Message-ID: <20090107012048.K45399@maildrop.int.zabbadoz.net> References: <20081215220539.W97918@maildrop.int.zabbadoz.net> <20081216053058.GA37217@amp2.iem.pw.edu.pl> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-current@freebsd.org Subject: Re: need conf/kern.post.mk review X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jan 2009 01:25:07 -0000 On Tue, 16 Dec 2008, Andrzej Tobola wrote: Hi, > If we are already on kern.port.mk what about the following patch > which gives the posibility to instal to fs without chflags (e.g. nfs) ? > I am using it from a long time as can be seen from time-stamps. > > --- /usr/src/sys/conf/kern.post.mk-OLD 2007-03-24 06:35:08.000000000 +0100 > +++ /usr/src/sys/conf/kern.post.mk 2007-11-24 23:52:03.000000000 +0100 > @@ -14,6 +14,12 @@ > .endif > MKMODULESENV+= KERNBUILDDIR="${.CURDIR}" > > +.if defined(NO_FSCHG) > +CHFLAGS= echo > +.else > +CHFLAGS= chflags -R noschg > +.endif > + > .MAIN: all > > .for target in all clean cleandepend cleandir clobber depend install \ > @@ -208,11 +214,11 @@ > .if exists(${DESTDIR}${KODIR}) > -thiskernel=`sysctl -n kern.bootfile` ; \ > if [ ! "`dirname "$$thiskernel"`" -ef ${DESTDIR}${KODIR} ] ; then \ > - chflags -R noschg ${DESTDIR}${KODIR} ; \ > + ${CHFLAGS} ${DESTDIR}${KODIR} ; \ > rm -rf ${DESTDIR}${KODIR} ; \ > else \ > if [ -d ${DESTDIR}${KODIR}.old ] ; then \ > - chflags -R noschg ${DESTDIR}${KODIR}.old ; \ > + ${CHFLAGS} ${DESTDIR}${KODIR}.old ; \ > rm -rf ${DESTDIR}${KODIR}.old ; \ > fi ; \ > mv ${DESTDIR}${KODIR} ${DESTDIR}${KODIR}.old ; \ > @@ -231,7 +237,7 @@ > > > kernel-reinstall: > - @-chflags -R noschg ${DESTDIR}${KODIR} > + @-${CHFLAGS} ${DESTDIR}${KODIR} > ${INSTALL} -p -m 555 -o root -g wheel ${KERNEL_KO} ${DESTDIR}${KODIR} > .if defined(DEBUG) && !defined(INSTALL_NODEBUG) > ${INSTALL} -p -m 555 -o root -g wheel ${KERNEL_KO}.symbols ${DESTDIR}${KODIR} I cannot see why you would need any of those changes. All three places do not care if they fail. the shell commands are using ; so the next command is just executed and kernel-reinstall has a - which means that a non-zero exist status is ignored. /bz -- Bjoern A. Zeeb The greatest risk is not taking one.