From owner-svn-src-head@freebsd.org Fri Jun 15 21:34:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4D1CD101D7AE; Fri, 15 Jun 2018 21:34:35 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com [IPv6:2607:f8b0:400e:c00::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B8C6084CAA; Fri, 15 Jun 2018 21:34:34 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pf0-x235.google.com with SMTP id a12-v6so5444101pfi.3; Fri, 15 Jun 2018 14:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3WZXTQJHA9SxZ2tfjxNqCPdxg3ryT4G7eGT+uDrq5ko=; b=urYdXN3x6O/6dYTCjKMQ+foahrthuoHRvmCFhDn7GR2gBO4M8h6p48+adJGWrQdMI8 Y5I3bdpZ9IAkuCGcXQwFmMlYj5E99GEr0FYjvo9FQhfjT7rgxUQFAlusNmbK6SdT9yua QuYkUtVafHQ6/+bDFQ+mRoZHZMkbcyAL1YS9dH/xYxPw3qdOv0P2eFYmtmtTBYtJ0Inp LaFB7QUW/TwBjes4EHmasfQyMRtCsOU1YW3put8iCJ+/T3bOtdwaC//tEvPy3uJw2FVW 1/LE7I6NjAKEmF/sMI6dNWmCigHETVOszwukpCktoICS7fyGwa5UZfRBV3p4z+x7W2/X Rv4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3WZXTQJHA9SxZ2tfjxNqCPdxg3ryT4G7eGT+uDrq5ko=; b=nFRmAGu6JWsNg9GmlvRjcmJn5EXMvYiPYIhyMd1olFJN3zSnm5XGCWK1dHQP5q2v99 nRxKDhKlJKdSmEwWgNyXDtDUZ0Mlp6cXCBq3SUkjlA8Dtv8N1yWjhTLzbdNLW/6fJmsO 3gSzqMMmcaMD0eSHWk/Z367WrYKFpn023Q+JVMCo2Bcw3jGAE5eoV5GQDp0OiRJS8k3Y i91Y/PISPPCzRgqbLCu9DFmmJsnjqI47OFF7Ce634c6tiEA/trJOdIYbYg/2xuSKOyyr UxZ5QQKbEFyse17kAB1Vo+f4m+gcmCSMtPN4mvSbmzxv86rpjYa4DwvMG1L4BaUvv2wa MaWQ== X-Gm-Message-State: APt69E01bqXLTReYfGsga6DSiRR2+uagnF2cf0cnHDwh9s37ZySOD7KZ JJtyFnl4AvhkIi4Dje2yNMp04Q== X-Google-Smtp-Source: ADUXVKI9adzSDK9UMZ7P04tWkigyiik8F8ZXy6ooHFIUqg+5XfnT8bhbPHiSXbfgEDiCd6oT9GCHJw== X-Received: by 2002:a63:69c4:: with SMTP id e187-v6mr3046528pgc.294.1529098473524; Fri, 15 Jun 2018 14:34:33 -0700 (PDT) Received: from [10.192.166.0] (stargate.chelsio.com. [12.32.117.8]) by smtp.googlemail.com with ESMTPSA id m16-v6sm10438078pgu.67.2018.06.15.14.34.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jun 2018 14:34:32 -0700 (PDT) Sender: Navdeep Parhar Subject: Re: svn commit: r335223 - head/sys/dev/cxgbe To: cem@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201806151804.w5FI4i46064041@repo.freebsd.org> From: Navdeep Parhar Openpgp: preference=signencrypt Autocrypt: addr=np@FreeBSD.org; prefer-encrypt=mutual; keydata= xsDiBEosaGcRBACOXnXquGEW53BjpMt2jViod/TUf1xgjMekcbDxqOODPeX7eYfrwJ8G6BCN OpGjBmWDu/JcNj4Z+gmTilJ6WLZQ7ecFZfEeO91pt6ys0cyWh0xfO+/mT83D7W81S/kqrJBk QbBIdV6LumevdErHo272r8RcMELC4Ru87eRtX3hmEwCgnnGNJMpQFUfYTt5XE7nY0yQoeV8D /0OcWmJbEZWxX9O7AuliCe3zd2Dw0B4LB9SZ2Dis7+gpVd3xVgYnt5wRE9kM+ThgrMA/wqr8 07qmEG6bcfUsfwwGN9YUtNF3xAN07cXTs026sCIFNZK816PrThBzCgkwR7pDpkMzGWIBr8Wi XXy0eB+JlQ6UV4PEiXuZ5ulzP0b1A/9CZm3wJfrNC0r1gMyrfVedg4zwKU997bmPLGcYs+rW XDTI9CvMseOUYn4CoDZQCp/9zxuHK+VU7Y/w0c/hVE5ERACSn4SjN2unEDstK9njZBMHEPVk Ae/YvSG5cmc97SHlVE+eu/bbLKcvFb6rRLPOaVFQJMJA2VJEGWtYhvP7Zc0fTmF2ZGVlcCBQ YXJoYXIgPG5wQEZyZWVCU0Qub3JnPsJgBBMRAgAgBQJKLGhnAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQyrIrk6yriBL0MQCfUJOiS2PbJFDeiav1ylcXXwfpggAAoJRoS7GDENGy M4BzjJ4b0ptZqTLRzsFNBEosaGcQCACFCWs47SL4DQA6bNDlVJu4w8wLf8uVOyatuGmdXX8Y /OTVQJgA3vS+ODNVJCxhKVlvhcn7bhBdGdWKS9K+lr8+eEvr4hf2bQpesoHC+uFgKyILkCBN L8raixbhysyq0pfZWWDJMyn+G42BG1yJJi+bykygdpYnbIVA8dYHmBibI8mkPKOHSohjXT1S RfGGn+l1w54OO4NlJhCXMkjTA/Z9Bt4XeaiR85uJi0UUfV8FGZHhgSvT+/P1xIvz+nytuehS P/QLXl13CtAG/nKVkAcZnsT/3NrJ4Z2r45k+c50Wrf210scAaBogrrV5eIHfNGgOANApN8+8 vj+aXO4pXRuXAAMFB/44ea8rd+P5N3OMrfuM8i91Qe1bJ+BIoroKPOr8jvCry0h3QpdfLKUN IgaqbS3JZeBJ8HHnWSGCF+o6H5gzRe1hvylPEclLPDCuPe7T746h9Mzejf2hNDJvOg+BuweD ZW4KhovVbdS+syJEvpGF4bO8qgHT2CKgruXSHbFetdQWbkM0rfMmTuo0GcR2BEVrPb/SPFv6 4ZZyAZzmnGO4vT1bzClnTzJixrDpH74M3vSEYegMB4KdbLYBi8Jx4QUKgVEhJHjJubKWX4et yU/uuehOC3xYrmr1UXvsom3U8r36Dvdo77Yr3dgDVXa7bolNx0TIhdWxZI+R4z9E75QY+/wg wkkEGBECAAkFAkosaGcCGwwACgkQyrIrk6yriBI+JQCfUxgyqGtzZvLh5Al7gsTmRc11PLwA niD3NfWGRcO2+9uxSSQqRH1ywC4n Message-ID: Date: Fri, 15 Jun 2018 14:34:31 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 21:34:35 -0000 I'm all for these sysctls becoming %intr_cpus and %local_cpus and being filled up by the device's parent automatically. But I'd like to tweak the output a bit so that it can be fed directly to cpuset -l. Regards, Navdeep On 06/15/18 14:14, Conrad Meyer wrote: > This seems generally useful, and nothing about the code is specific to > cxgbe. Could it be adapted to be driver-agnostic? > > Thanks, > Conrad > > On Fri, Jun 15, 2018 at 11:04 AM, Navdeep Parhar wrote: >> Author: np >> Date: Fri Jun 15 18:04:44 2018 >> New Revision: 335223 >> URL: https://svnweb.freebsd.org/changeset/base/335223 >> >> Log: >> cxgbe(4): sysctls to display the local and intr CPUs for the adapter. >> ... >> +} >> + >> +static int >> +sysctl_cpus(SYSCTL_HANDLER_ARGS) >> +{ >> ... >> + rc = bus_get_cpus(sc->dev, op, sizeof(cpuset), &cpuset); >> + if (rc != 0) >> + return (rc); >> + >> ... >> + CPU_FOREACH(i) >> + sbuf_printf(sb, "%d ", i); >> + rc = sbuf_finish(sb); >> + sbuf_delete(sb);