From owner-svn-src-head@FreeBSD.ORG Mon Aug 30 21:33:33 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4E5310656A6; Mon, 30 Aug 2010 21:33:33 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id B4D758FC13; Mon, 30 Aug 2010 21:33:33 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o7ULXXvF008429; Mon, 30 Aug 2010 21:33:33 GMT (envelope-from delphij@svn.freebsd.org) Received: (from delphij@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o7ULXXH8008427; Mon, 30 Aug 2010 21:33:33 GMT (envelope-from delphij@svn.freebsd.org) Message-Id: <201008302133.o7ULXXH8008427@svn.freebsd.org> From: Xin LI Date: Mon, 30 Aug 2010 21:33:33 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r212028 - head/sys/dev/twa X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2010 21:33:33 -0000 Author: delphij Date: Mon Aug 30 21:33:33 2010 New Revision: 212028 URL: http://svn.freebsd.org/changeset/base/212028 Log: Drain watchdog callouts before detaching. This prevents a panic while unloading the kernel module. Submitted by: Tom Cough Modified: head/sys/dev/twa/tw_osl_freebsd.c Modified: head/sys/dev/twa/tw_osl_freebsd.c ============================================================================== --- head/sys/dev/twa/tw_osl_freebsd.c Mon Aug 30 21:20:24 2010 (r212027) +++ head/sys/dev/twa/tw_osl_freebsd.c Mon Aug 30 21:33:33 2010 (r212028) @@ -903,6 +903,10 @@ twa_shutdown(device_t dev) /* Disconnect interrupts. */ error = twa_teardown_intr(sc); + /* Stop watchdog task. */ + callout_drain(&(sc->watchdog_callout[0])); + callout_drain(&(sc->watchdog_callout[1])); + /* Disconnect from the controller. */ if ((error = tw_cl_shutdown_ctlr(&(sc->ctlr_handle), 0))) { tw_osli_printf(sc, "error = %d",