From owner-freebsd-current@freebsd.org Tue Nov 10 02:06:10 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7E012A2A593 for ; Tue, 10 Nov 2015 02:06:10 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 632EF130C; Tue, 10 Nov 2015 02:06:10 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 5BA2B1E80; Tue, 10 Nov 2015 02:06:10 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 310B417020; Tue, 10 Nov 2015 02:06:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id OhAN0ff6d0Ey; Tue, 10 Nov 2015 02:06:07 +0000 (UTC) Subject: Re: Failing buildword due to execution permission (with fix) DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 0B40717019 To: Garrett Cooper , Bryan Drewery References: <233C431B-1675-4A55-A46E-B1B858056A09@gmail.com> <564136A0.4080406@FreeBSD.org> <5655EBD2-5EC5-425E-82B9-F7FF30312F02@gmail.com> <564147FF.2050107@FreeBSD.org> <45AD4F5D-DABD-47ED-99FA-A40FFFF3CC7E@gmail.com> Cc: =?UTF-8?B?Sm9zw6kgUMOpcmV6?= , freebsd-current@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <5641510E.4020602@FreeBSD.org> Date: Mon, 9 Nov 2015 18:06:06 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <45AD4F5D-DABD-47ED-99FA-A40FFFF3CC7E@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Du9p4GPfUBOQvJWkB9lHtJRUVl5WoujMH" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 02:06:10 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Du9p4GPfUBOQvJWkB9lHtJRUVl5WoujMH Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/9/2015 6:01 PM, Garrett Cooper wrote: >=20 >> On Nov 9, 2015, at 17:27, Bryan Drewery wrote: >> >>> On 11/9/2015 5:17 PM, Garrett Cooper wrote: >>> >>>> On Nov 9, 2015, at 16:13, Bryan Drewery wrote= : >>> >>> >>> ... >>> >>>> If this is a shell file then it is best to invoke it with 'sh' rathe= r >>>> than a chmod/#!. The src checkout should be noexec-safe. >>> >>> Right. I think it'd be a good idea for me to hunt down other issues t= hough in the build by setting -o noexec. >>> >>> >>> The only thing that concerns me with doing that is that it could resu= lt in weirdness, e.g. The osreldate.h generation script in include/ . >> >> It prepends 'sh'. >> >> include/Makefile:MK_OSRELDATE_SH=3D ${.CURDIR}/mk-osreldate.sh >> include/Makefile: sh ${MK_OSRELDATE_SH} >=20 > Yeah... I forgot. >=20 > I wrote up that patch at iX, and it was iterated over a bit. I was just= remembering what happens when you use ${SHELL} (hint: no bueno if your b= uild is kicked off with a csh/non-POSIX sh..). >=20 I actually wrote up a patch recently to use ${SH} in all places of 'sh' and '/bin/sh', and noted on SHELL?=3D that was not useful to use, but did= not commit it (yet). --=20 Regards, Bryan Drewery --Du9p4GPfUBOQvJWkB9lHtJRUVl5WoujMH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWQVEOAAoJEDXXcbtuRpfPEIwIAIBNXV6TAYDFJj8kHVlI24Rv 6z8LlWR6eFxmni4TG9KihuibzJtf7V2/C2Zun0N3KHu5/tmygLbp0PJqyCkj4dYn QaZneBTtfMH9/Vr/b6J1V/3i33UenXgB43AdT/hlKwvYsiSIyMh6m+agIb+Eh2ay D2NIB6B0zaSIQenX5/ZtUnDFGq4RShyKDimHGSgb0NSksdhcV/G8ayn94B2NFf/7 Y4DMqEBnfU6mYXsFRymH/9Q1behZYDpPgg7ABYpPndR9tQXXJ9/MXuyXlD05JCBa VoNpz2nf685kIdZqYHVnpD+1Nls9vnT36eZYwtGh0U65HcqeFNTkP2qcI5VYyzw= =2gRP -----END PGP SIGNATURE----- --Du9p4GPfUBOQvJWkB9lHtJRUVl5WoujMH--