From owner-svn-ports-all@FreeBSD.ORG  Wed Jan 22 01:33:52 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id DFFE5D29; Wed, 22 Jan 2014 01:33:52 +0000 (UTC)
Date: Wed, 22 Jan 2014 01:33:52 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Alex Dupre <ale@FreeBSD.org>
Subject: Re: svn commit: r340618 - head/security/cryptlib
Message-ID: <20140122013352.GA12715@FreeBSD.org>
References: <201401211633.s0LGXRLP049969@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201401211633.s0LGXRLP049969@svn.freebsd.org>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jan 2014 01:33:52 -0000

On Tue, Jan 21, 2014 at 04:33:27PM +0000, Alex Dupre wrote:
> New Revision: 340618
> URL: http://svnweb.freebsd.org/changeset/ports/340618
> QAT: https://qat.redports.org/buildarchive/r340618/
> 
> +OPTIONS_DEFINE=		DOCS

Couple of observations. :)

OPTIONS are normally placed below all other knobs (traditionally).

> +	${LN} -sf ${PREFIX}/lib/libcl.so.${PORTVERSION} ${STAGEDIR}${PREFIX}/lib/libcl.so.3
> +	${LN} -sf ${PREFIX}/lib/libcl.so.3 ${STAGEDIR}${PREFIX}/lib/libcl.so

Per our own wiki.freebsd.org/ports/StageDir:

  "When creating a symlink, prepend ${STAGEDIR} to the target path only (and
   generally try to avoid using absolute paths in source). [...]

   Note that source of ${PREFIX}/lib/libfoo.so.42, while seemingly okay,
   could be in fact incorrect, since absolute path can potentially point to
   a wrong location, e.g. when remote filesystem (with installed package)
   is mounted via NFS under non-root mount point. Relative paths are less
   fragile (and often much shorter)."

./danfe