From owner-svn-src-all@FreeBSD.ORG Mon Aug 4 03:00:59 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7BC029E9 for ; Mon, 4 Aug 2014 03:00:59 +0000 (UTC) Received: from mail-ig0-f178.google.com (mail-ig0-f178.google.com [209.85.213.178]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3F1432199 for ; Mon, 4 Aug 2014 03:00:58 +0000 (UTC) Received: by mail-ig0-f178.google.com with SMTP id uq10so4573045igb.11 for ; Sun, 03 Aug 2014 20:00:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=eS/zKehDsSOn/Rx0CsRsF5L+mp6Uyp/TMYhQKHugKJA=; b=PZk2o9IM4hh/o0p8/PJGZ7f7mxJxinR+g8yCIzKe78qmX2V45jzthnK53pT4Phrqf9 89MJdN/J/q6Dsq2LiqIksRE/G4SrDFqxaCmudM6G1F8SS30dncSBes5Glb8SN+mF9cqc YrslINi6o1KiL+uNcgxtg1pHzDdAeoLEhAd4UHRA6LbQAFHK8O3Kb821rVSygcpt24V3 VWfVgkGFUhLOBmaNYDPRv7Ta22nAlHiIPT9MB5PjyLYJTIEni97HNDsRyUB437jwHwTU 8UnB7aox8xoVUdeZAW6mPaJhC7ajNRyGEY3Klluv8yWJruFkowdj57I6eaaw5Fv3idls Aq9g== X-Gm-Message-State: ALoCoQnUiO3rkoth0hBOjCogEFag/6tmpfWVH/o1K4Cjr9efyBFyRpEQqWNWi0cAoHyZOZeBWIOw X-Received: by 10.50.43.193 with SMTP id y1mr31808862igl.32.1407120859345; Sun, 03 Aug 2014 19:54:19 -0700 (PDT) Received: from netflix-mac.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id z4sm42287071igp.14.2014.08.03.19.54.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 03 Aug 2014 19:54:18 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_89DBBDC5-E4C8-4CE1-9A39-D98AE8BE62ED"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r268943 - in head: include lib/libc/stdlib From: Warner Losh In-Reply-To: <6A2B0200-EB23-459B-8E3F-6B1151C90D0E@freebsd.org> Date: Sun, 3 Aug 2014 20:54:15 -0600 Message-Id: References: <201407211522.s6LFMnQo084633@svn.freebsd.org> <53CD430F.5040604@fastmail.net> <68E8EDB9-64DE-4037-9047-C8BEAD86801A@freebsd.org> <65378493-7F05-4314-9809-E689891F6067@gmail.com> <6A2B0200-EB23-459B-8E3F-6B1151C90D0E@freebsd.org> To: Pedro Giffuni X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, Bruce Simpson , src-committers@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Aug 2014 03:00:59 -0000 --Apple-Mail=_89DBBDC5-E4C8-4CE1-9A39-D98AE8BE62ED Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Aug 3, 2014, at 9:39 AM, Pedro Giffuni wrote: >=20 > Il giorno 03/ago/2014, alle ore 09:27, Warner Losh ha = scritto: >=20 >>=20 >> On Jul 21, 2014, at 12:51 PM, Pedro Giffuni wrote: >>=20 >>>=20 >>> Il giorno 21/lug/2014, alle ore 11:42, Bruce Simpson = ha scritto: >>>=20 >>>> On 21/07/2014 16:22, Pedro F. Giffuni wrote: >>>>> ] >>>>> Log: >>>>> Add re-entrant versions of the hash functions based on the GNU = api. >>>>>=20 >>>> What, if anything, can be done about qsort_r() API incompatibility? >>>=20 >>> qsort_r is non-standard and we did it first, plus we will want to = stay compatible with Apple :). >>>=20 >>> I guess we could do some ugly parameter swapping in the case where = _GNU_SOURCE >>> is defined, but I won=92t volunteer to do that. >>=20 >> Are there any ABI considerations for the change? >>=20 >=20 > I would keep the qsort_r() ABI unchanged and add a GNU-compatible = version that is used only when _GNU_SOURCE (but not _BSD_SOURCE) is = defined. >=20 > This would already be pretty messy by itself because some portable = code may define _GNU_SOURCE but still may try to use the Apple/BSD = interface under another #ifdef. Perhaps it=92s just better to leave our = headers alone and let the end-users do the wrapping. If there=92s no ABI change, then I don=92t care what we do about a = non-standard API. However, once we=92ve made an API public, standard or = do, we have to support that ABI essentially forever when libc is = involved. Warner --Apple-Mail=_89DBBDC5-E4C8-4CE1-9A39-D98AE8BE62ED Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJT3vXXAAoJEGwc0Sh9sBEAFWEP/3K8hwDJ+65zbTP+hz5C/qD0 FsSKOAZvocc29uzsRvq31uKw91+KMPRTBzwXmsBkdT7Z32XZ5YlpF5IA3DOXXfUf E3dbqd+lqXzvIqUZmWUvPaBWqhd5Jxb2un4qt5ZZDaYTTbttGPPYLuIyevn/vbk7 0Y8f18z8dO6jLbvGdjg11uDrKojYaQQXIqsK6XIKmVHX5lcJDNx0htrZ4QAo2hUc H3JM5Q7G3sJucN01OJrQZzlC/RC2RDh5ZQP2HbYvFWBxkFRWz0cD8XOIPjE9zS16 s448xczGUFJIKWdcN3pUFyIx3mXhbHp4bhBg0rr4VG8QWlwqTUBsOTA4RLALLB81 PjQhxHwFkeTyNXI6KuO8WOyCtsuai71JqrTTYivSXfPrKl3RwfqRewBw03qk4bmN AoZFrwMPtRF9ef8ropxo+BWamcfWd7QaBiJvJe31CgtKSX0YVTfg2nmDOgtnzaq1 lkv8Ctr/UhcDqeI7aPdBCRelasT75vNQkJ7Grx1iQ/rDpiudm/F870Qo4cXrVL2/ wQ/xvGjCWsU5+xMVG/IQVpSSsDvH24o5LEpU26nV7BEukKAGqGIa2eWsY/K5vvGt NGQ8qQsrAuyqX8rD7JxjM0SNHXWbZWI2S7EHQ/IVeFiHvg9JQ2PWYC+WmPV/v9BI +JRPvYfJPUym3QVXcxrr =CNMc -----END PGP SIGNATURE----- --Apple-Mail=_89DBBDC5-E4C8-4CE1-9A39-D98AE8BE62ED--