From owner-freebsd-java@FreeBSD.ORG  Tue Nov 11 21:11:59 2014
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: java@freebsd.org
Received: from hammer.pct.niksun.com (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by hub.freebsd.org (Postfix) with ESMTP id BE89B44F;
 Tue, 11 Nov 2014 21:11:58 +0000 (UTC)
Message-ID: <54627B9E.7060600@FreeBSD.org>
Date: Tue, 11 Nov 2014 16:11:58 -0500
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Antoine Brodin <antoine@FreeBSD.org>, Greg Lewis <glewis@freebsd.org>, 
 java@freebsd.org
Subject: Re: svn commit: r372338 - in head/java: openjdk8 openjdk8-jre
 openjdk8/files
References: <201411090523.sA95NWMT062480@svn.freebsd.org>
 <CAALwa8n0SPavW=BjoMLaPJOy+Dib4oZcyaL8b9SvCuzjiDVzWg@mail.gmail.com>
In-Reply-To: <CAALwa8n0SPavW=BjoMLaPJOy+Dib4oZcyaL8b9SvCuzjiDVzWg@mail.gmail.com>
Content-Type: multipart/mixed; boundary="------------030604060103060501070001"
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-java>,
 <mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java/>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
 <mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Nov 2014 21:11:59 -0000

This is a multi-part message in MIME format.
--------------030604060103060501070001
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/11/2014 06:38, Antoine Brodin wrote:
> On Sun, Nov 9, 2014 at 6:23 AM, Greg Lewis <glewis@freebsd.org>
> wrote:
>> Author: glewis Date: Sun Nov  9 05:23:31 2014 New Revision:
>> 372338 URL: https://svnweb.freebsd.org/changeset/ports/372338 
>> QAT: https://qat.redports.org/buildarchive/r372338/
>> 
>> Log: . Update to 8u25.
>> 
> 
> Hi,
> 
> This fails to build on i386 (10.1RCX):
> 
> Compiling ../generated/adfiles/ad_x86_32.cpp 
> /wrkdirs/usr/ports/java/openjdk8-jre/work/openjdk/hotspot/src/cpu/x86/vm/x86_32.ad:1213:1:
>
> 
error: control may reach end of non-void function
> [-Werror,-Wreturn-type] } ^ 1 error generated. 
> /wrkdirs/usr/ports/java/openjdk8-jre/work/openjdk/hotspot/make/bsd/makefiles/rules.make:154:
>
> 
recipe for target 'ad_x86_32.o' failed

Please try the attached patch.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJUYnueAAoJEHyflib82/FGDQgH/i9q+yQHcRLnrgK50UNxxJoZ
QgLnEf1CSXmSNzcFh1moN4WqVQ+QYSXvHgEWxp00aavgnbUSKabGULNAucIRNGvc
n9lk4XayGUWpB0PofpQsVcUKQLbkTDJCCkma8niXTkXdYGo/nybKg+Ai71dKfKWd
GmwzsG2yBHMjnm4pg62YLyDcHHexOmD1nbG4niUANbeNv3MvK0LewmOo41PZ8Q/H
NLLuDGLekRI80XbGYanONOx3WoSM/cXV1CK42j9LiBs3cQz7myr0Ejhauq9WhoJP
RfplwN1ArIhCI8faFmUYJM8XsKaiJw64oEfQ+mrIiPs/BJa1wZy6AuOltrCBgfA=
=/Dlc
-----END PGP SIGNATURE-----

--------------030604060103060501070001
Content-Type: text/x-patch;
 name="openjdk8.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="openjdk8.diff"

Index: java/openjdk8/files/patch-bsd
===================================================================
--- java/openjdk8/files/patch-bsd	(revision 372461)
+++ java/openjdk8/files/patch-bsd	(working copy)
@@ -2218,6 +2218,16 @@
    #define JNIEXPORT     __attribute__((visibility("default")))
    #define JNIIMPORT     __attribute__((visibility("default")))
  #else
+--- ./hotspot/src/cpu/x86/vm/x86_32.ad	2014-11-11 15:50:09.000000000 -0500
++++ ./hotspot/src/cpu/x86/vm/x86_32.ad	2014-11-11 16:05:43.000000000 -0500
+@@ -1210,6 +1210,7 @@
+ 
+ 
+   Unimplemented();
++  return 0;
+ }
+ 
+ #ifndef PRODUCT
 --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
 +++ ./hotspot/src/os/bsd/vm/decoder_bsd.cpp	Wed Nov 05 15:01:44 2014 -0800
 @@ -0,0 +1,47 @@

--------------030604060103060501070001--