From owner-cvs-sbin Sun Oct 13 13:56:11 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA05485 for cvs-sbin-outgoing; Sun, 13 Oct 1996 13:56:11 -0700 (PDT) Received: (from joerg@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA05442; Sun, 13 Oct 1996 13:55:50 -0700 (PDT) Date: Sun, 13 Oct 1996 13:55:50 -0700 (PDT) From: Joerg Wunsch Message-Id: <199610132055.NAA05442@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/savecore savecore.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk joerg 96/10/13 13:55:49 Modified: sbin/savecore savecore.c Log: Yikes! Originally, i intended to apply the patch from PR # 1322, but Bill has beaten me on this. ;-) However, he missed the part to compute the kernelsize in kilobytes, so the minfree consideration was now overcautious. (I've also changed the return type of dump_size() to void since int was useless.) Being here, the fact that `vmcore' was written world-readable was just a plain security hole: everybody who was able to crash a kernel could later read any confidential information out of it at his will. Create it with umask 077 instead. Revision Changes Path 1.16 +6 -5 src/sbin/savecore/savecore.c