Date: Thu, 16 Jul 2015 11:10:22 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, Dmitry Marakasov <amdmi3@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r392209 - in head/devel: . p5-Minilla Message-ID: <20150716091021.GW37597@ivaldir.etoilebsd.net> In-Reply-To: <20150716014306.GA68880@FreeBSD.org> References: <201507152017.t6FKHElA056017@svnmir.geo.freebsd.org> <F55E1B42FC419AF2D5795884@atuin.in.mat.cc> <20150716014306.GA68880@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--j13PAD5Nz8dz2ik7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Jul 16, 2015 at 01:43:06AM +0000, Alexey Dokuchaev wrote:
> On Wed, Jul 15, 2015 at 10:38:33PM +0200, Mathieu Arnold wrote:
> > +--On 15 juillet 2015 20:17:14 +0000 Dmitry Marakasov <amdmi3@FreeBSD.o=
rg>
> > wrote:
> >=20
> > | +RUN_DEPENDS:=3D ${BUILD_DEPENDS}
> >=20
> > Please, do *not* use :=3D for depends, it is wrong.
> > <https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.=
html>
>=20
> Can you clarify on what is wrong with :=3D ? I've added IMHO quite clear=
and
> elaborate explanation in the PH on the matter, and I don't see the merit =
of
> using MY_DEPENDS at all: it's ugly, it's hard to read, it pollutes namesp=
ace
> for no sound reason.
>=20
> People should learn their tools instead of inventing obscure workarounds.
>=20
:=3D enforce the expansion to happen right away
Let's say you have:
RUN_DEPENDS=3D ${BLOODYSCRIPTLANGUAGEPREFIX}bal>0:${PORTSDIR}/somewhere/bla
BULID_DEPENDS:=3D ${RUN_DEPENDS}
=2Einclude <bsd.port.mk>
BULID_DEPENDS will magically have ${BLOODYSCRIPTLANGUAGEPREFIX} expanded to=
""
because it is not yet defined at the moment the expansion is requested.
Bapt
--j13PAD5Nz8dz2ik7
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlWndP0ACgkQ8kTtMUmk6EyC/QCgkAXCcvMYaLAILri/Ckajfb4P
LE4AoJIVS9VTm3lM1OZjHPwx35YWJlBc
=IRPX
-----END PGP SIGNATURE-----
--j13PAD5Nz8dz2ik7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150716091021.GW37597>