From owner-freebsd-current@FreeBSD.ORG Mon Apr 15 20:12:47 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 94120AD9; Mon, 15 Apr 2013 20:12:47 +0000 (UTC) (envelope-from Cy.Schubert@komquats.com) Received: from smtp-out-01.shaw.ca (smtp-out-01.shaw.ca [64.59.136.137]) by mx1.freebsd.org (Postfix) with ESMTP id 20D1817AC; Mon, 15 Apr 2013 20:12:47 +0000 (UTC) X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=SNukfclIDc7GjKe+LHtSoPUBJt/gHPuqMk7EpfoOdzs= c=1 sm=1 a=QrugwKR0C_UA:10 a=wAGQQ9Az6v0A:10 a=BLceEmwcHowA:10 a=ICAaq7hcmGcA:10 a=kj9zAlcOel0A:10 a=IbtKDeXwb2+SRU442/pi3A==:17 a=6I5d2MoRAAAA:8 a=BWvPGDcYAAAA:8 a=N9rBXh7b3HRsED3skiAA:9 a=CjuIK1q_8ugA:10 a=SV7veod9ZcQA:10 a=V7tsTZBp22UA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Received: from unknown (HELO spqr.komquats.com) ([96.50.7.119]) by smtp-out-01.shaw.ca with ESMTP; 15 Apr 2013 14:11:33 -0600 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTP id 872BE80; Mon, 15 Apr 2013 13:12:40 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.14.6/8.14.6) with ESMTP id r3FKCdI3085567; Mon, 15 Apr 2013 13:12:39 -0700 (PDT) (envelope-from Cy.Schubert@komquats.com) Message-Id: <201304152012.r3FKCdI3085567@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.5 From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: Gleb Smirnoff Subject: Re: ipfilter(4) needs maintainer In-Reply-To: Message from Gleb Smirnoff of "Mon, 15 Apr 2013 23:55:44 +0400." <20130415195544.GY76816@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 15 Apr 2013 13:12:39 -0700 Cc: Warren Block , Scott Long , "current@freebsd.org" , Chris Rees , Rui Paulo , "net@freebsd.org" , "cpet@sdf.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Cy Schubert List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Apr 2013 20:12:47 -0000 In message <20130415195544.GY76816@FreeBSD.org>, Gleb Smirnoff writes: > Cy, > > good news that you volunteered to work on this! > > On Mon, Apr 15, 2013 at 10:48:43AM -0700, Cy Schubert wrote: > C> The initial plan was to import IP Filter 5.1.2 into HEAD. darrenr@ hadn't > C> done much with IPF while employed with Sun. Since then there has been some > > C> development that is long overdue for HEAD. > > The problem is that v5.1.2 is under GPL. I'm afraid we should update > to v4.1.34 only, and then stick to it. So the nearest TODO list > is smth like: > > - update to v4.1.34 > - cleanse old kernel APIs (timeout(9) at least) > - fix VIMAGE > - review open PRs (some might should be closed) > - since we do not expect more imports, may be cleanse non-FreeBSD stuff > from there? > - maybe move it into sys/netpfil? Need to consult imp@ on that. License > is very closed to BSD, but has some additions. A small step in the right direction is a good thing. I'll run the patches by you first. The existing license isn't that BSD-friendly either, which is why it lives in contrib/. I think the 5.1.X GPLv2 is about the same friendliness as Darren's IPF 4.1.X license. As long as it's not in GENERIC should be fine. A person can always load it anyway. > > C> I'm not sure if I'd MFC it into 9 or not. > > This is up to you, but be adviced that head already differs from stable/9, > for example network stack is entirely in network byte order. So merging > would require a lot of attention and testing. > > C> I did consider a port but given it would has to touch bits and pieces of > C> the source tree (/usr/src), a port would be messy and the decision was mad > e > C> to work on importing it into base. > > Port isn't an option. IPFilter is too close to many kernel APIs, that > can change quickly. Agreed. I looked at it a few months ago and determined that src is where it should be. (I put it aside, getting ACER WMI/ACPI working on my new Acer laptop was my priority at the time.) -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org