From owner-cvs-all@FreeBSD.ORG  Fri May 23 02:04:16 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1598F37B401; Fri, 23 May 2003 02:04:16 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C77B043F75; Fri, 23 May 2003 02:04:13 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id TAA06063;
	Fri, 23 May 2003 19:04:10 +1000
Date: Fri, 23 May 2003 19:04:09 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Doug Barton <DougB@FreeBSD.org>
In-Reply-To: <20030522163523.R2984@znfgre.qbhto.arg>
Message-ID: <20030523185605.D47768@gamplex.bde.org>
References: <20030522183930.564EF37B49D@hub.freebsd.org>
	<20030522161035.X95941@root.org>
	<20030522163523.R2984@znfgre.qbhto.arg>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Nate Lawson <nate@root.org>
Subject: Re: cvs commit: src/sbin/newfs mkfs.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 May 2003 09:04:16 -0000

On Thu, 22 May 2003, Doug Barton wrote:

> On Thu, 22 May 2003, Nate Lawson wrote:
>
> > Actually there's a style bug in that the chdummy line is spaces not
> > tabs.  This contributed to me missing it.  :)
>
> There are other style(9) violations in that same file, so I didn't think
> this one was important enough to worry about, and I wanted to get the fix
> in as reviewed asap. Perhaps my judgement was faulty...

mkfs.c had fewer KNF violations than most files in the system.  With
the exception of the declarations before the functions, I could only
find formatting errors on about 13 lines using indent(1) (indent(1)
with certain options fixed about 13 lines and broke about 30).  The
global declarations are harder to check because indent(1) would misformat
them all, but they are obvioslu all misformatted because they are
mostly missing tabs.

The patch has several very obvious style bugs -- long lines.

Bruce