From nobody Fri Aug 8 16:37:33 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bz8pC08Wkz649Cl; Fri, 08 Aug 2025 16:37:39 +0000 (UTC) (envelope-from philip@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bz8pB6FCCz3qLH; Fri, 08 Aug 2025 16:37:38 +0000 (UTC) (envelope-from philip@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754671058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZXQ6P4Uxs4PXenyg5MsfiZHnTXvVsVbS0/pVPHNH7b0=; b=yMHCdSRX2OOX92b55bFl8YlaYg1OOQTuwa2enBegl3oZMJsGyRZ6iFuqYjIKdfqSwIhR6g BrddVW3i+B8i+km/EPRYw2ewtOl0HpMMysSH5WLw2H13tIyYvH0Hylp+tlyg19Aqhozit7 0urwWf3ePVKW9etbxAl7JKylbjW0c2EBwIvl/sAMPcy/FfGlUM5A4TBMWHvlhDFLzgioEn HHBFbehcugiKg8F8lUQvV6e2dFnKtO9Wahbp0nMOpcUNuhlhOgLyX9YyFHxz0Yc7T7+r9a odUNPJVXy36CBRoQ5KKeA1V/tl9AJYhre6cnAaN+hGc9gsmgLl1C+Al4j7ahXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754671058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZXQ6P4Uxs4PXenyg5MsfiZHnTXvVsVbS0/pVPHNH7b0=; b=ko6z/I9ktNBMzbXmZirbsOt4FLkAw+V6QuzZaSH2rOa36QCk85KKcjVgn/0/fVSONJ8ogr Uh4hVm1bnms4TI1oJZZ5KAHUx/MrFIeo9gp7vHtyRQOcY8HWGLT68I6F9MvU5bFZEOCSvX l43+xK8JyuifZAg2zKJ9c+/S+74i3+Sn074s3d6/0HiV5Q8xvWUncUMCnQoDrkALm0NYjD SyNDsaXy7b5w096n8CdeMQwfA3iTnAUC/WFM0p1ndIKswQScRhLfWwyfWzO2Grbtb69JUu B/zfKSyBuaYNOjdzKzwOABHpwKbyGJ4jpeLg+EImzI6v0j83syPTXUtzPJWH4g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754671058; a=rsa-sha256; cv=none; b=rAmuJMdFdKcn21vMp2D4aq+J24H+hD2vAsHUnhgt8fWXB4k4v5H8GXfJPJowTULHxUwkVo chd/mwel78eqeA5YDGX54zQXXCH9AJ1gA+p9G3Rd0ZoCBH88B10wH9A6GZuF/XLrWhiUYl pSLYmbAQX00pJg4+DjyFoKqHhdEI5yN1cdJeGf5+Wr26fnIqPX4HQcvkulT+kZGhRwjXw/ 4BrHjZnr1ZcZdy4BagXyh9YBoab4iXiHRKFWZY3Lf6JJ2e+Ls5bFBzVuQ0PmouN1yXDwVE /8oK66MbASRU9Nbgul8b5n7vUnnGGzOCQAf4tA1+/7bDEqWVcqUC+IzQGXQBig== Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com [103.168.172.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: philip/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bz8pB4tG8zM8h; Fri, 08 Aug 2025 16:37:38 +0000 (UTC) (envelope-from philip@freebsd.org) Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfauth.phl.internal (Postfix) with ESMTP id 09920F40066; Fri, 8 Aug 2025 12:37:38 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Fri, 08 Aug 2025 12:37:38 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduvdegfeduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtugfgjghofgesth ekredttderjeenucfhrhhomheprfhhihhlihhpucfrrggvphhsuceophhhihhlihhpsehf rhgvvggsshgurdhorhhgqeenucggtffrrghtthgvrhhnpeeigefhheffvdffieduueffve egjeejtedtveeuueeileffieefvddvteeuvddvudenucffohhmrghinhepfhhrvggvsghs ugdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehphhhilhhiphdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudduieei vdeivdegkedqvdefhedukedttdekqdhphhhilhhipheppehfrhgvvggsshgurdhorhhgse htrhhouhgslhgvrdhishdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhht pdhrtghpthhtohepuggvshesfhhrvggvsghsugdrohhrghdprhgtphhtthhopehsrhgtqd gtohhmmhhithhtvghrshesfhhrvggvsghsugdrohhrghdprhgtphhtthhopeguvghvqdgt ohhmmhhithhsqdhsrhgtqdgrlhhlsehfrhgvvggsshgurdhorhhgpdhrtghpthhtohepug gvvhdqtghomhhmihhtshdqshhrtgdqmhgrihhnsehfrhgvvggsshgurdhorhhg X-ME-Proxy: Feedback-ID: ia691475d:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Aug 2025 12:37:35 -0400 (EDT) Date: Sat, 9 Aug 2025 00:37:33 +0800 From: Philip Paeps To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6dab48b9de6c - main - build: Switch CLEAN back on by default Message-ID: Mail-Followup-To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202508081559.578FxjHP094672@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202508081559.578FxjHP094672@gitrepo.freebsd.org> X-PGP-Fingerprint: B851 CD3A C248 F2ED 3E2C C18C BB6D 8A14 AFE7 D96B X-Date: Today is Sweetmorn, the 2nd day of Bureaucracy in the YOLD 3191 X-Phase-of-Moon: The Moon is Waxing Gibbous (99% of Full) X-Clacks-Overhead: GNU Terry Pratchett Organization: Happily Disorganized User-Agent: Mutt/2.2.14 (2025-02-20) On 2025-08-08 15:59:45 (+0000), Dag-Erling Smørgrav wrote: >The branch main has been updated by des: > >URL: https://cgit.FreeBSD.org/src/commit/?id=6dab48b9de6c1bff61b0ce78029c1e3cba20895a > >commit 6dab48b9de6c1bff61b0ce78029c1e3cba20895a >Author: Dag-Erling Smørgrav >AuthorDate: 2025-08-08 15:57:31 +0000 >Commit: Dag-Erling Smørgrav >CommitDate: 2025-08-08 15:57:31 +0000 > > build: Switch CLEAN back on by default > > There have been too many issues with non-META_MODE incremental builds > recently, and it is clear that most users, even developers, were not > aware that the default had been switched. > > This will be revisited once more work has been done to help prevent > future breakage. > > This reverts commit ba373fca78a114768244d6a8c27983da870c1169. > > Reviewed by: markj, jhb > Differential Revision: https://reviews.freebsd.org/D51828 Thank you! Maybe we should just flip CLEAN on for a couple of days/weeks when there's something disruptive on main that benefits from thorough cleaning, but have it off by default? As I understand it, doing pkgbase builds with CLEAN rebuilds all packages, and pkg will want to update them even if the binaries within are unchanged. We set WITHOUT_CLEAN=1 in the cluster pkgbase builder to try to make sure that doesn't happen. I would love to put that flag under developers' control so pkgbase package production doesn't stall when a WITH_CLEAN=1 build is needed. Philip -- Philip Paeps Senior Reality Engineer Alternative Enterprises