From owner-freebsd-hackers Tue Nov 12 20:52:32 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id UAA24469 for hackers-outgoing; Tue, 12 Nov 1996 20:52:32 -0800 (PST) Received: from parkplace.cet.co.jp (parkplace.cet.co.jp [202.32.64.1]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id UAA24458 for ; Tue, 12 Nov 1996 20:52:22 -0800 (PST) Received: from localhost (michaelh@localhost) by parkplace.cet.co.jp (8.8.2/CET-v2.1) with SMTP id EAA11364; Wed, 13 Nov 1996 04:52:14 GMT Date: Wed, 13 Nov 1996 13:52:14 +0900 (JST) From: Michael Hancock To: Thomas David Rivers cc: FreeBSD Hackers Subject: Re: Even more info on daily panics... In-Reply-To: <199611130143.UAA16800@lakes.water.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk IMHO, it's not good to speculate. You need to confirm with absolute certainty that the patch is what actually fixed it. You might want to do either of the following: 1) Remove the patch and see if what happens. 2) Put in print statements and see if the relevent section of code ever gets executed. See other #ifdef DIAGNOSTICS for examples of how to do this. I think vrele() had one. Regards, Mike Hancock On Tue, 12 Nov 1996, Thomas David Rivers wrote: > > Well - just a status update... > > It's now been 5+ days since I installed the kernel with > the vrele() panic and Terry's other vfs_subr.c fix... > > The machine has yet to panic, at all...: > > ponds# uptime > 8:31PM up 5 days, 7:34, 1 user, load averages: 0.33, 0.55, 0.60 > > At this point, my only explanation is that I must have > installed the wrong kernel when originally testing Terry's > change to vfs_subr.c; and, in fact, Terry's suggested change > to not walk around the end of the list is the reason for > the success I'm having. It seems to me it couldn't have > been the other change to vrele() which is simply to add > some consistency checks that weren't present before. > > I'd like to ensure this improvement makes it into 2.1.6... (I believe > it's already in -current.) Who do I talk to for that? > > - Dave Rivers - >